Run stardis tests on Tardis PRs #2753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2753 +/- ##
===========================================
+ Coverage 36.47% 69.26% +32.79%
===========================================
Files 183 191 +8
Lines 14664 15021 +357
===========================================
+ Hits 5348 10405 +5057
+ Misses 9316 4616 -4700 ☔ View full report in Codecov by Sentry. |
atharva-2001
requested changes
Jul 29, 2024
| - name: Install TARDIS | ||
| id: install-tardis | ||
| run: | | ||
| pip install git+https://github.com/tardis-sn/tardis.git@${{ github.sha }} |
There was a problem hiding this comment.
does this work when triggered from master, have you tried other test cases?
There was a problem hiding this comment.
Workflow Dispatch:
https://github.com/KasukabeDefenceForce/tardis/actions/runs/10143033368/job/28043570915
Pull Request:
KasukabeDefenceForce#34
atharva-2001
approved these changes
Jul 29, 2024
andrewfullard
approved these changes
Jul 29, 2024
jvshields
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Type: 🪲
bugfix| 🚀feature| ☣️breaking change| 🚦testing| 📝documentation| 🎢infrastructureThis PR aims at adding a workflow which runs stardis tests on tardis PRs, in order to better identify what code changes might break stardis
Also, link issues affected by this pull request by using the keywords:
close,closes,closed,fix,fixes,fixed,resolve,resolvesorresolved.📌 Resources
Examples, notebooks, and links to useful references.
🚦 Testing
How did you test these changes?
☑️ Checklist
build_docslabel