Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LFS Fixes #2954

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

LFS Fixes #2954

wants to merge 5 commits into from

Conversation

atharva-2001
Copy link
Member

@atharva-2001 atharva-2001 commented Jan 23, 2025

📝 Description

Type: 🪲 bugfix | 🚀 feature | ☣️ breaking change | 🚦 testing | 📝 documentation | 🎢 infrastructure

  • Removes the runner_os since both platforms use the same LFS
  • Allows caching only the atom data file for benchmarks
  • Adds documentation for the cache keys

📌 Resources

Examples, notebooks, and links to useful references.

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@tardis-bot
Copy link
Contributor

tardis-bot commented Jan 23, 2025

*beep* *bop*
Hi human,
I ran ruff on the latest commit (eddc976).
Here are the outputs produced.
Results can also be downloaded as artifacts here.
Summarised output:

25	W291	[*] Trailing whitespace
5	E902	[ ] No such file or directory (os error 2)
5	E999	[ ] SyntaxError: Expected a statement
5	W293	[*] Blank line contains whitespace
4	F401	[ ] `tardis.plasma.equilibrium.rates.collision_strengths.UpsilonCMFGENSolver` imported but unused; consider removing, adding to `__all__`, or using a redundant alias
2	W292	[*] No newline at end of file

Complete output(might be large):

.github/actions/setup_env/action.yml:4:8: E999 SyntaxError: Expected an expression
.github/actions/setup_env/action.yml:17:1: W293 [*] Blank line contains whitespace
.github/actions/setup_env/action.yml:19:15: W291 [*] Trailing whitespace
.github/actions/setup_env/action.yml:24:1: W293 [*] Blank line contains whitespace
.github/actions/setup_lfs/action.yml:5:8: E999 SyntaxError: Expected an expression
.github/workflows/benchmarks.yml:3:4: E999 SyntaxError: Expected an expression
.github/workflows/benchmarks.yml:20:5: W291 [*] Trailing whitespace
.github/workflows/benchmarks.yml:84:49: W291 [*] Trailing whitespace
.github/workflows/benchmarks.yml:114:81: W291 [*] Trailing whitespace
.github/workflows/benchmarks.yml:115:54: W291 [*] Trailing whitespace
.github/workflows/benchmarks.yml:202:1: W293 [*] Blank line contains whitespace
.github/workflows/benchmarks.yml:221:22: W291 [*] Trailing whitespace
.github/workflows/benchmarks.yml:222:170: W291 [*] Trailing whitespace
.github/workflows/benchmarks.yml:224:84: W291 [*] Trailing whitespace
.github/workflows/benchmarks.yml:241:1: W293 [*] Blank line contains whitespace
docs/contributing/development/continuous_integration.rst:1:1: E999 SyntaxError: Expected a statement
docs/contributing/development/continuous_integration.rst:16:76: W291 [*] Trailing whitespace
docs/contributing/development/continuous_integration.rst:18:68: W291 [*] Trailing whitespace
docs/contributing/development/continuous_integration.rst:21:92: W291 [*] Trailing whitespace
docs/contributing/development/continuous_integration.rst:22:86: W291 [*] Trailing whitespace
docs/contributing/development/continuous_integration.rst:72:1: W293 [*] Blank line contains whitespace
docs/contributing/development/continuous_integration.rst:106:70: W291 [*] Trailing whitespace
docs/contributing/development/continuous_integration.rst:121:78: W291 [*] Trailing whitespace
docs/contributing/development/continuous_integration.rst:122:94: W291 [*] Trailing whitespace
docs/contributing/development/continuous_integration.rst:123:83: W291 [*] Trailing whitespace
docs/contributing/development/continuous_integration.rst:124:96: W291 [*] Trailing whitespace
docs/contributing/development/continuous_integration.rst:126:97: W291 [*] Trailing whitespace
docs/contributing/development/continuous_integration.rst:127:62: W291 [*] Trailing whitespace
docs/contributing/development/continuous_integration.rst:134:90: W291 [*] Trailing whitespace
docs/contributing/development/continuous_integration.rst:135:19: W292 [*] No newline at end of file
docs/contributing/development/running_tests.rst:1:1: E999 SyntaxError: Expected a statement
docs/contributing/development/running_tests.rst:59:112: W291 [*] Trailing whitespace
docs/contributing/development/running_tests.rst:60:124: W291 [*] Trailing whitespace
docs/contributing/development/running_tests.rst:64:92: W291 [*] Trailing whitespace
docs/contributing/development/running_tests.rst:65:99: W291 [*] Trailing whitespace
docs/contributing/development/running_tests.rst:75:62: W291 [*] Trailing whitespace
docs/contributing/development/running_tests.rst:76:85: W292 [*] No newline at end of file
docs/physics/plasma/equilibrium/tardis_solver_cmfgen.ipynb:1:1: E902 No such file or directory (os error 2)
tardis/plasma/equilibrium/rates/__init__.py:2:5: F401 `tardis.plasma.equilibrium.rates.collision_strengths.UpsilonCMFGENSolver` imported but unused; consider removing, adding to `__all__`, or using a redundant alias
tardis/plasma/equilibrium/rates/__init__.py:3:5: F401 `tardis.plasma.equilibrium.rates.collision_strengths.UpsilonRegemorterSolver` imported but unused; consider removing, adding to `__all__`, or using a redundant alias
tardis/plasma/equilibrium/rates/__init__.py:6:5: F401 `tardis.plasma.equilibrium.rates.collisional_rates.ThermalCollisionalRateSolver` imported but unused; consider removing, adding to `__all__`, or using a redundant alias
tardis/plasma/equilibrium/rates/__init__.py:9:5: F401 `tardis.plasma.equilibrium.rates.radiative_rates.RadiativeRatesSolver` imported but unused; consider removing, adding to `__all__`, or using a redundant alias
tardis/plasma/equilibrium/rates/collisional_ionization_rates.py:1:1: E902 No such file or directory (os error 2)
tardis/plasma/equilibrium/rates/collisional_ionization_strengths.py:1:1: E902 No such file or directory (os error 2)
tardis/plasma/equilibrium/rates/photoionization_rates.py:1:1: E902 No such file or directory (os error 2)
tardis/plasma/equilibrium/rates/photoionization_strengths.py:1:1: E902 No such file or directory (os error 2)
Found 46 errors.
[*] 32 fixable with the `--fix` option.

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.17%. Comparing base (145a995) to head (eddc976).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2954      +/-   ##
==========================================
- Coverage   69.74%   69.17%   -0.57%     
==========================================
  Files         224      228       +4     
  Lines       16313    16427     +114     
==========================================
- Hits        11377    11363      -14     
- Misses       4936     5064     +128     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atharva-2001 atharva-2001 marked this pull request as ready for review January 24, 2025 14:12
@tardis-bot
Copy link
Contributor

*beep* *bop*

Hi, human.

The docs workflow has succeeded ✔️

Click here to see your results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: waiting for review
Development

Successfully merging this pull request may close these issues.

3 participants