Skip to content
This repository has been archived by the owner on Dec 25, 2023. It is now read-only.

Commit

Permalink
refactor(code): changes after
Browse files Browse the repository at this point in the history
  • Loading branch information
tarsisexistence committed May 8, 2019
1 parent c198511 commit 73bdb23
Show file tree
Hide file tree
Showing 5 changed files with 4 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
[nzMode]="'horizontal'">

<a nz-menu-item navLink="{{ slices.about.root.state }}">About</a>
<a nz-menu-item [navLink]="slices.automobile.root.state" navLinkActive="myActiveClass">Automobiles</a>
<a nz-menu-item [navLink]="slices.automobile.root.state" navLinkActive="my-active-class">Automobiles</a>
<a nz-menu-item [navLink]="slices.bike.root">Bikes</a>
<a nz-menu-item [navLink]="slices.bolid.root" [navLinkActive]="['myActiveClass']">
Bolids
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,6 @@
line-height: 64px;
}

.myActiveClass {
.my-active-class {
font-weight: 900;
}
2 changes: 1 addition & 1 deletion example-app/app/routing/hub/app.slice.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { createRoot, Slice } from '../../../../package';
import { appNotes, AppNotes as R } from './app.notes';
import { AppChildrenNotes as C } from './app-children.notes';
import { createRoot, Slice } from '../../../../package';

/**
* Hub initialization
Expand Down
1 change: 0 additions & 1 deletion package/src/navigation/navigation-link-active.directive.ts
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,6 @@ export class NavigationLinkActive
const href = instance.href
? instance.href
: insertHrefParams(getRouteHref(instance.link), instance.params);
console.log(url, href);
return exact ? url === href : url.includes(href);
}
}
2 changes: 1 addition & 1 deletion package/src/public_api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export {

export { rootNote } from './generators';

export { forwardParams, forwardHrefParams } from './utils/state';
export { forwardParams } from './utils/state';

export { createRoot, createFeature } from './creators';

Expand Down

0 comments on commit 73bdb23

Please sign in to comment.