Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add list of all core permissions [issue #2966] #2970

Merged
merged 10 commits into from
Nov 14, 2024

Conversation

514sid
Copy link
Contributor

@514sid 514sid commented Nov 12, 2024

Related to issue #2966

@514sid 514sid requested a review from a team as a code owner November 12, 2024 07:46
Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for tauri-v2 ready!

Name Link
🔨 Latest commit e34b8d8
🔍 Latest deploy log https://app.netlify.com/sites/tauri-v2/deploys/6735fab35634190008a8a2a0
😎 Deploy Preview https://deploy-preview-2970--tauri-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@FabianLars
Copy link
Member

Thanks! I think for the future automating this may make sense (like we do for the plugins) 🤔 But for now this is totally fine.

@tweidinger idk if you care but are you okay with this being on the security/capabilities/ page or would you prefer some other location?

@tweidinger
Copy link
Contributor

tweidinger commented Nov 13, 2024

I think this kind of reference should be part of a reference/acl/core-capabilities.mdx file.
Agreed on it is okay to have it manually for now but should be automatically generated from the already generated markdown of the crate (https://github.com/tauri-apps/tauri/blob/dev/crates/tauri/permissions/app/autogenerated/reference.md for example).

This shouldn't live in the guide section where the concept of a capability is explained.

@514sid
Copy link
Contributor Author

514sid commented Nov 13, 2024

I think this kind of reference should be part of a reference/acl/core-capabilities.mdx file.

If the list of capabilities is added to this file, I think it would be nice to include a link to it at /security/capabilities/

Co-authored-by: Fabian-Lars <[email protected]>
Copy link
Member

@FabianLars FabianLars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks :)

@FabianLars FabianLars merged commit 7283397 into tauri-apps:v2 Nov 14, 2024
9 checks passed
@514sid 514sid deleted the core-permissions branch November 14, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants