fix: call ctx.drop_finish in webkit2gtk drop handler (#1412)

tauri-apps · Nov 8, 2024 · 9a2a2d4 · 9a2a2d4
1 parent 7c4f2b7
commit 9a2a2d4
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/.changes/gnome-dragged-icon-stuck.md b/.changes/gnome-dragged-icon-stuck.md
@@ -0,0 +1,5 @@
+---
+"wry": "patch"
+---
+
+Fix icons of dragged items getting stuck when using `WebViewBuilder::with_drag_drop_handler` on some distros like Gnome.
diff --git a/src/webkitgtk/drag_drop.rs b/src/webkitgtk/drag_drop.rs
@@ -92,9 +92,10 @@ pub(crate) fn connect_drag_event(webview: &WebView, handler: Box<dyn Fn(DragDrop
 
   {
     let controller = controller.clone();
-    webview.connect_drag_drop(move |_, _, x, y, _| {
+    webview.connect_drag_drop(move |_, ctx, x, y, time| {
       if controller.has_entered() {
         if let Some(paths) = controller.take_paths() {
+          ctx.drop_finish(true, time);
           controller.leave();
           return controller.call(DragDropEvent::Drop {
             paths,