Added WebView::load_html #1058
Closed
Added WebView::load_html #1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested on Android using cargo-mobile2, seems to be working properly. |
VictorKoenders
force-pushed
the
add_webview_load_html
branch
from
4398589 to
6b1f0e8
Compare
|
Rebased onto |
|
Also tested in Windows/macOS/ubuntu |
amrbashir
approved these changes
Nov 13, 2023
|
@VictorKoenders looks like you didn't sign your commits and I can't merge the PR unless they are signed. You need to setup commit signing, then you can sign past commit like this for example. |
|
This totally fell out of my radar, thanks @VictorKoenders for the PR though and apologies for keeping it this long |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
Other information
There is currently
WebViewBuilder::with_htmlbut there is no way to load in HTML after theWebViewhas been constructed. This is an attempt at adding that.I have only tested this on Windows right now. The other platforms still need testing / fixing. Please chip in if you can test or have feedback.