Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Change Comments On Fork-based PRs #1303

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Conversation

jbolda
Copy link
Member

@jbolda jbolda commented Jun 27, 2024

Motivation

PRs from forks were failing as they don't have the permissions to comment to the PR. With changes upstream in covector and adding a workflow_run, we can enable these comments to be securely created.

@jbolda jbolda requested a review from amrbashir June 27, 2024 21:58
@jbolda jbolda requested a review from a team as a code owner June 27, 2024 21:58
Copy link
Contributor

Package Changes Through 5a46dc3

There are 1 changes which include wry with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
wry 0.41.0 0.41.1

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@jbolda
Copy link
Member Author

jbolda commented Jun 27, 2024

Note we will switch back to a tagged CI run once the next version is merged in: jbolda/covector#317.

@amrbashir amrbashir merged commit 1520343 into dev Jun 28, 2024
13 checks passed
@amrbashir amrbashir deleted the change-comments-on-forks branch June 28, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants