fix(example): workaround to prevent winit crash when unfocused #1323
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a workaround for issue #1318
Root cause
In Wry, we replace the content view with
WryWebViewParent
to pass key events to the application menu. When the window is unfocused, winit will callWindowDelegate::window_did_resign_key
and get thecontentView
. It assumes thecontentView
isWinitView
and gets its ivar_state
. The ivar does not exist in ourWryWebViewParent
, so the exception is thrown.Workaround
WebViewBuilder::new_as_child
will not createWryWebViewParent
to replace thecontentView
, so it will be safe to use in winit.