fix(linux): don't share UserContentManager between webviews (dev) #1326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes tauri-apps#1308 Init scripts are registered to the UserContentManager, so if it is shared between webviews, the init scripts will conflict. Use a unique UserContentManager for each WebView instead of sharing it across the WebContext.
Package Changes Through 3f1263dThere are 1 changes which include wry with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
|
Note: This doesn't completely fix opening multiple windows with |
amrbashir
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1308
Init scripts are registered to the
UserContentManager, so if it is shared betweenWebViews, the init scripts conflict. IPC handlers are also tied to theUserContentManager. Use a uniqueUserContentManagerfor eachWebViewinstead of sharing it across theWebContext.Corresponding PR on the v0.24 branch: #1325