Skip to content

Commit

Permalink
Rewritten contributing
Browse files Browse the repository at this point in the history
  • Loading branch information
tcalmant committed Aug 26, 2024
1 parent 74a675f commit f24a321
Show file tree
Hide file tree
Showing 3 changed files with 97 additions and 104 deletions.
96 changes: 96 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,96 @@
# How to contribute

All contributions to iPOPO are always welcome.

## Issues & Feedback

Issues must be described on the [GitHub repository](https://github.com/tcalmant/ipopo/issues).

Feedback is always greatly appreciated and should be given on the
[ipopo-users](https://groups.google.com/g/ipopo-users) mailing list.

New features can be requested either as an *Enhancement* issue or
discussed on the users mailing list.

## Code contribution

In order io contribute code to iPOPO, you must fork the project then use
[GitHub Pull Requests](https://github.com/tcalmant/ipopo/pulls). Your
code will be reviewed, tested and inserted into the master branch.

Your code style must follow some rules, described in the following section.

If you don't write documentation or tests, I'll write some of them; but
contributing both of them will increase the changes of your pull request
to be accepted.

Note that your contributions must be released under the project's license, which
is the [Apache Software License 2.0](https://www.apache.org/licenses/LICENSE-2.0).

## Code Style

Overall, try to respect [PEP-8](https://peps.python.org/pep-0008/).

If you use PyCharm or VS Code, most of the rules described here are
already checked.

An [EditorConfig](https://editorconfig.org/) is available in the repository:
you should make sure your IDE loads it, either natively or using a plugin
(*e.g.* [EditorConfig for VS Code](https://marketplace.visualstudio.com/items?itemName=EditorConfig.EditorConfig)).

### General

- Your code must be compatible with Python 3.10+.
- Use type hints wherever possible
- Prefer using typed service specifications instead of named ones in Pelix and iPOPO
- Use `logging` instead of printing out debug traces.
- Use list, set and dictionary comprehension when possible.
- Remove unused imports.
- Imports must be after module documentation and before anything else.
- All modules must have a `__version_info__` tuple and a matching `__version__` string.

### Formatting

- Rule of thumb: use [black](https://pypi.org/project/black/) to format your files
- Avoid inline comments; use 2 spaces when using them (mainly for type hinting)
- Break long lines after **110** characters. Exception for URLs.
- Delete trailing whitespace.
- Don't include spaces after `(`, `[`, `{` or before `}`, `]`, `)`.
- Don't misspell in method names.
- Don't vertically align tokens on consecutive lines.
- Use 4 spaces indentation (no tabs).
- Use an empty line between methods.
- Use 2 empty lines before class definitions.
- Use spaces around operators.
- Use spaces after commas and colons.
- Use Unix-style line endings (`\n`).
- Use 3 double-quotes (`"""`) for documentation

### Naming

- Use `CamelCase` for class names.
- Use `SNAKE_UPPERCASE` for constants.
- Use `snake_case` for method names.
- `CamelCase` is allowed for decorator methods.
- First argument of:
- instance methods must be `self`
- class methods must be `cls`

### Organization

Documentation about a new feature should be added to a new file in
`docs/refcards`.
Documentation is compiled with [Sphinx](https://www.sphinx-doc.org/) and
supports both reStructuredText and Markdown (with
[MyST](https://myst-parser.readthedocs.io/)).

New features implementations can be added either to an existing or to a new
`pelix` subpackage. You should not add new modules to the root `pelix`
package.

Tests should be added to either an existing or a new sub-folder of `tests`.
Unit tests are executed using `pytest` and based on `unittest`.

You can also provide new samples in the `samples` folder. They must come
as a `run_XXX.py` entry-point script and an `XXX` package containing all
the sample bundles.
103 changes: 0 additions & 103 deletions CONTRIBUTING.rst

This file was deleted.

2 changes: 1 addition & 1 deletion MANIFEST.in
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
include LICENSE
include README.rst
include docs/changelog.md
include CONTRIBUTING.rst
include CONTRIBUTING.md
include _imgs/ipopo_logo.png

0 comments on commit f24a321

Please sign in to comment.