Add Newsletter section and adjust main containers #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://kulturdaten-website-frontend-pr-22.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cj97g21itvpc73bjf8b0. |
Merged
herrherrmann
force-pushed
the
newsletter-section
branch
from
57cd935 to
62dcf97
Compare
ZenVega
reviewed
Aug 9, 2023
added 10 commits
August 9, 2023 17:29
…etter background work
herrherrmann
force-pushed
the
newsletter-section
branch
from
62dcf97 to
d366784
Compare
|
Habe mich gerade gefragt, ob wir die bisherigen h3 durch h2 ersetzen wollen. Momentan haben wir folgende semantische Struktur: Wenn ich mir das figma ansehe dürfte sich das auch nicht mehr verändern. |
ZenVega
approved these changes
Aug 10, 2023
|
Guter Punkt mit den Headings! Hab’s jetzt umgebastelt, sodass es so aussieht:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the new NewsletterSection to our HomePage, including related changes around Buttons (we now need buttons that are links) and our main layout. As discussed with @BugBoomBang, we are now trying out a wider maximum with for the main layout (800px). We also have a new
<Text>component that we can use and expand for our future text/paragraph/headline needs!