-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add website footer #27
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
7dbaed3
Adjust Link component to use our blue color and allow more props
07c8213
Wrap Next.js’ Link component with our styles (as LinkInternal)
b611305
Add website footer
8164926
Footer: Remove Section in favor of new horizontalPagePadding variable
3904f0c
Footer: Slightly improve naming of container components
d2d8268
Define strong font-weight globally
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -30,6 +30,18 @@ | |
"title": "Ihr macht die Kultur, wir sagen allen Bescheid", | ||
"subtitle": "kulturdaten.berlin – für Kulturakteur:innen", | ||
"description": "Was? Wann? Wer? Wo? Für wen? Wie lange? Um im Web gefunden zu werden, müssen Kulturschaffende ihr Programm an vielen Stellen mühsam händisch einpflegen. Mit der Plattform kulturdaten.berlin wollen wir diesen Prozess radikal vereinfachen! \n\nDeswegen entwickeln wir gemeinsam mit Kulturakteur:innen und -institutionen die erste offene, digitale Infrastruktur für Kulturdaten in Berlin: Gefördert durch die Senatsverwaltung für Kultur und Europa entsteht zurzeit eine zentrale Datendrehscheibe, die ihre Kulturdaten strukturieren, bündeln und mit zahlreichen Portalen zielgerichtet vernetzen kann. \n\nNatürlich können nicht nur Institutionen, sondern insbesondere auch Kollektive und Solokünstler:innen ihre Profile und Angebote über kulturdaten.berlin publizieren." | ||
}, | ||
"footer": { | ||
"address-title": "Adresse", | ||
"address-content": "Technologiestiftung Berlin\nGrunewaldstr. 61-62\n10825 Berlin", | ||
"email-title": "E-Mail", | ||
"email-content": "[email protected]", | ||
"link-privacy-policy": "Datenschutzrichtlinie", | ||
"link-imprint": "Impressum", | ||
"project-by": "Ein Projekt der", | ||
"supported-by": "gefördert von", | ||
"tsb-logo-alt": "Technologiestiftung Berlin", | ||
"sen-kugz-logo-alt": "Senatsverwaltung für Kultur und Gesellschaftlichen Zusammenhalt Berlin" | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -30,6 +30,18 @@ | |
"title": "You do the culture, we’ll let everyone know", | ||
"subtitle": "kulturdaten.berlin - for cultural actors", | ||
"description": "What? When? Who? Where? For whom? For how long? In order to be found on the web, cultural professionals have to painstakingly enter their programs manually in many places. With the platform kulturdaten.berlin we want to radically simplify this process! \n\nThat’s why we’re working with cultural actors and institutions to develop the first open, digital infrastructure for cultural data in Berlin. Funded by the Senate Department for Culture and Europe, we’re currently creating a central data hub that can structure and bundle cultural data and network it with numerous portals in a targeted manner. \n\nOf course, not only institutions, but also collectives and solo artists in particular can publish their profiles and offerings via kulturdaten.berlin." | ||
}, | ||
"footer": { | ||
"address-title": "Address", | ||
"address-content": "Technologiestiftung Berlin\nGrunewaldstr. 61-62\n10825 Berlin", | ||
"email-title": "E-mail", | ||
"email-content": "[email protected]", | ||
"link-privacy-policy": "Privacy policy", | ||
"link-imprint": "Imprint", | ||
"project-by": "A project by", | ||
"supported-by": "supported by", | ||
"tsb-logo-alt": "Technologiestiftung Berlin", | ||
"sen-kugz-logo-alt": "Senatsverwaltung für Kultur und Gesellschaftlichen Zusammenhalt Berlin" | ||
} | ||
} | ||
} |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,80 @@ | ||
import styled from "@emotion/styled"; | ||
import { useTranslations } from "next-intl"; | ||
import { colors, spacings, widths } from "../../../common/styleVariables"; | ||
import Link, { LinkInternal } from "../../Link"; | ||
import Spacer from "../../Spacer"; | ||
|
||
const StyledFooter = styled.footer({ | ||
width: `min(100%, ${widths.maxContentWidth})`, | ||
padding: `${spacings.get(10)}px ${spacings.horizontalPagePadding}`, | ||
margin: "0 auto", | ||
backgroundColor: colors.grayLight, | ||
color: colors.blueDark, | ||
}); | ||
|
||
const Row = styled.div({ | ||
display: "flex", | ||
flexWrap: "wrap", | ||
gap: spacings.get(5), | ||
justifyContent: "space-between", | ||
}); | ||
|
||
const Address = styled.address({ | ||
flex: "0 1 40%", | ||
fontStyle: "normal", | ||
}); | ||
|
||
const Title = styled.strong(); | ||
|
||
const Content = styled.div({ | ||
whiteSpace: "pre-line", | ||
}); | ||
|
||
const PageLinks = styled.div({ | ||
flex: "0 1 40%", | ||
display: "flex", | ||
flexDirection: "column", | ||
}); | ||
|
||
const LogoTitle = styled.div({ | ||
marginBottom: spacings.get(2), | ||
}); | ||
|
||
export default function Footer() { | ||
const t = useTranslations("Home.footer"); | ||
return ( | ||
<StyledFooter> | ||
<Row> | ||
<Address> | ||
<Title>{t("address-title")}</Title> | ||
<Content>{t("address-content")}</Content> | ||
<br /> | ||
<Title>{t("email-title")}</Title> | ||
<Content> | ||
<Link href={`mailto:${t("email-content")}`}>{t("email-content")}</Link> | ||
</Content> | ||
</Address> | ||
<PageLinks> | ||
<LinkInternal href="/privacy-policy">{t("link-privacy-policy")}</LinkInternal> | ||
<Spacer size={4} /> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Gleicher Punkt wie oben gap vs Spacer |
||
<LinkInternal href="/imprint">{t("link-imprint")}</LinkInternal> | ||
</PageLinks> | ||
</Row> | ||
<Spacer size={50} /> | ||
<Row> | ||
<div> | ||
<LogoTitle>{t("project-by")}</LogoTitle> | ||
<a href="https://www.technologiestiftung-berlin.de/" target="_blank"> | ||
<img src="/images/tsb-logo.svg" width={220} alt={t("tsb-logo-alt")} /> | ||
</a> | ||
</div> | ||
<div> | ||
<LogoTitle>{t("supported-by")}</LogoTitle> | ||
<a href="https://www.berlin.de/sen/kultgz/" target="_blank"> | ||
<img src="/images/sen-kugz-logo.svg" width={400} alt={t("sen-kugz-logo-alt")} /> | ||
</a> | ||
</div> | ||
</Row> | ||
</StyledFooter> | ||
); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,22 @@ | ||
import { ReactNode } from "react"; | ||
import styled, { CSSObject } from "@emotion/styled"; | ||
import NextLink from "next/link"; | ||
import { AnchorHTMLAttributes, ReactNode } from "react"; | ||
import { colors } from "../../common/styleVariables"; | ||
|
||
type Props = { | ||
const linkStyles: CSSObject = { | ||
color: colors.blueDark, | ||
textDecoration: "underline", | ||
"&:hover": { | ||
textDecoration: "none", | ||
}, | ||
}; | ||
const Link = styled.a<Props>(linkStyles); | ||
|
||
type Props = AnchorHTMLAttributes<HTMLAnchorElement> & { | ||
href: string; | ||
children: ReactNode; | ||
}; | ||
|
||
export default function Link(props: Props) { | ||
const { href, children } = props; | ||
return <a href={href}>{children}</a>; | ||
} | ||
export default Link; | ||
|
||
export const LinkInternal = styled(NextLink)(linkStyles); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Das hier ist vermutlich überfällig. Obwohl ich intuitiv in ner flexbox vermutlich schon mit nem gap anstatt mit dem spacer arbeiten würde. Vielleicht kann man da mal kurz was abquatschen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Der
gap
hier definiert den horizontalen Zwischenraum zwischen z.B. dem linken Block (mit Adresse und E-mail) und dem rechten Block (mit den beiden Links). Das habe ich hinzugefügt, damit die beiden Blöcke sich nicht bei bestimmten Bildschirmbreiten "berühren", sondern dann lieber in die nächste Zeile wrappen.Aber stimmt, statt
gap
könnte man innerhalb von<Row>
einen<Spacer />
verwenden. 🤔There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
… sprach er, aber irrte sich. Mit
gap
ist es viel leichter, das Wrapping gut abzubilden. Wenn man einen<Spacer />
dafür verwendet, ist dieser ggf. noch nicht in der nächsten "Zeile", obwohl das nächste Flex-Item schon in der nächsten Zeile ist. Von daher würde ich’s gern so lassen. :D