Structure concistency #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://kulturdaten-website-frontend-pr-56.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cjk9ojfjbvhs73fuliug. |
herrherrmann
requested changes
Aug 28, 2023
herrherrmann
force-pushed
the
structure-concistency
branch
from
79e004b to
9f33656
Compare
|
@ZenVega Ich habe mir mal die Freiheit genommen, die Imports zu entfernen und den Branch zu rebasen, sodass wir jetzt mergen können. Ansonsten würden sich (mit den neuen UI-Fixes) nur die Konflikte häufen. 💥 |
herrherrmann
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes no1 and no3 of issue #28.
I think we can for now keep the section thing as it is since it already got a better consistency