Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use config.defaultTransport instead of 'HTTP' #853

Merged
merged 4 commits into from
Jan 20, 2025
Merged

Use config.defaultTransport instead of 'HTTP' #853

merged 4 commits into from
Jan 20, 2025

Conversation

AlvaroVega
Copy link
Member

@AlvaroVega AlvaroVega commented Jan 16, 2025 •
edited
Loading

related: #852

  • Update tests

@AlvaroVega AlvaroVega changed the title Use config.defualtTransport instead 'HTTP' Use config.defaultTransport instead of 'HTTP' Jan 16, 2025
@AlvaroVega AlvaroVega changed the title Use config.defaultTransport instead of 'HTTP' [WIP] Use config.defaultTransport instead of 'HTTP' Jan 16, 2025
@AlvaroVega AlvaroVega changed the title [WIP] Use config.defaultTransport instead of 'HTTP' Use config.defaultTransport instead of 'HTTP' Jan 17, 2025
@AlvaroVega AlvaroVega mentioned this pull request Jan 17, 2025
Merged
@AlvaroVega AlvaroVega requested a review from fgalan January 20, 2025 07:36
fgalan
fgalan reviewed Jan 20, 2025
View reviewed changes
CHANGES_NEXT_RELEASE Outdated Show resolved Hide resolved
fgalan
fgalan approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@fgalan fgalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fgalan fgalan merged commit e5f0442 into master Jan 20, 2025
5 checks passed
@fgalan fgalan deleted the fix/use_default_transport_config branch January 20, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgalan fgalan fgalan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlvaroVega @fgalan