Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix check endpoint expression for http commands #854

Merged
merged 4 commits into from
Jan 20, 2025
Merged

fix check endpoint expression for http commands #854

merged 4 commits into from
Jan 20, 2025

Conversation

AlvaroVega
Copy link
Member

@AlvaroVega AlvaroVega commented Jan 16, 2025 •
edited
Loading

Bug introduced by #794

@AlvaroVega AlvaroVega changed the title [WIP] fix check endpoint expresison [WIP] fix check endpoint expression Jan 16, 2025
@AlvaroVega AlvaroVega changed the title [WIP] fix check endpoint expression fix check endpoint expression Jan 17, 2025
@AlvaroVega AlvaroVega marked this pull request as ready for review January 17, 2025 09:19
@AlvaroVega AlvaroVega requested a review from fgalan January 17, 2025 09:19
@AlvaroVega AlvaroVega changed the title fix check endpoint expression fix check endpoint expression for http commands Jan 20, 2025
fgalan
fgalan reviewed Jan 20, 2025
View reviewed changes
CHANGES_NEXT_RELEASE
@@ -1 +1,2 @@
- Fix: check endpoint expression when execute http command
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issue associated to this PR? (just to check...)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issue was created

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NTC

fgalan
fgalan approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@fgalan fgalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fgalan fgalan merged commit df25c83 into master Jan 20, 2025
4 of 5 checks passed
@fgalan fgalan deleted the fix/check_endpoint_exp branch January 20, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgalan fgalan fgalan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlvaroVega @fgalan