Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task/remove domain #327

Merged
merged 15 commits into from
Mar 12, 2024
Merged

Task/remove domain #327

merged 15 commits into from
Mar 12, 2024

Conversation

AlvaroVega
Copy link
Member

@AlvaroVega AlvaroVega commented Dec 12, 2023 •
edited
Loading

Fix for #268

@coveralls
Copy link

coveralls commented Feb 26, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8245533191

Details

  • 74 of 105 (70.48%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 76.205%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/services/protocols.js 8 9 88.89%
lib/services/iotaRedirector.js 22 24 91.67%
lib/services/protocolData.js 4 6 66.67%
lib/utils/logging.js 25 28 89.29%
lib/iotagent-manager.js 6 16 37.5%
lib/model/dbConn.js 2 15 13.33%
Totals Coverage Status
Change from base Build 8066887806: -0.3%
Covered Lines: 523
Relevant Lines: 651
💛 - Coveralls

@AlvaroVega AlvaroVega mentioned this pull request Feb 27, 2024
Open
@AlvaroVega AlvaroVega requested a review from fgalan March 12, 2024 07:24
@AlvaroVega AlvaroVega marked this pull request as ready for review March 12, 2024 07:25
fgalan
fgalan approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@fgalan fgalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fgalan fgalan merged commit 8cb2f09 into master Mar 12, 2024
6 checks passed
@fgalan fgalan deleted the task/remove_domain branch March 12, 2024 09:49
@fgalan fgalan mentioned this pull request Mar 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgalan fgalan fgalan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlvaroVega @coveralls @fgalan