Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use options=flowControl when update #1677

Merged
merged 13 commits into from
Jan 14, 2025
Merged

Conversation

AlvaroVega
Copy link
Member

@AlvaroVega AlvaroVega commented Dec 18, 2024

related #1420

This way measure response from iotagent relies on related ContextBroker update response

@fgalan
Copy link
Member

fgalan commented Jan 8, 2025

I'd suggest to make the inclusion of the flowControl option to be optional. I'd suggest to use the same approach that with another on/off features (eg. timestamp), that can be set at IOTA instance / group / device level, with the same precedence rules.

@fgalan fgalan mentioned this pull request Jan 8, 2025
4 tasks
@AlvaroVega AlvaroVega changed the title [WIP] use options=flowControl when update use options=flowControl when update Jan 14, 2025
@AlvaroVega AlvaroVega marked this pull request as ready for review January 14, 2025 09:31
@AlvaroVega AlvaroVega requested a review from fgalan January 14, 2025 10:49
CHANGES_NEXT_RELEASE Outdated Show resolved Hide resolved
CHANGES_NEXT_RELEASE Outdated Show resolved Hide resolved
doc/admin.md Outdated Show resolved Hide resolved
AlvaroVega and others added 3 commits January 14, 2025 12:59
Co-authored-by: Fermín Galán Márquez <[email protected]>
Co-authored-by: Fermín Galán Márquez <[email protected]>
Co-authored-by: Fermín Galán Márquez <[email protected]>
Copy link
Member

@fgalan fgalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fgalan fgalan merged commit b852a43 into master Jan 14, 2025
7 checks passed
@fgalan fgalan deleted the task/use_cb_flow_control_when_update branch January 14, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants