Add Ellison support #116
Add Ellison support #116
Conversation
Pull Request Test Coverage Report for Build 9033558128Details
💛 - Coveralls |
|
|
||
| return $sentence; | ||
| } | ||
| } |
There was a problem hiding this comment.
70 lines of awesome.
There was a problem hiding this comment.
Tis is super cool! Just a great PR without any remarks, but I didn't expect anything else from you Chris :D
Sorry for the late reply! I went down a rabbit hole in another project and wanted to solve that first before looking at my github notification again :D
| @@ -41,6 +42,7 @@ public function __construct( | |||
| ->addLanguage(new CssLanguage()) | |||
| ->addLanguage(new DiffLanguage()) | |||
| ->addLanguage(new DocCommentLanguage()) | |||
| ->addLanguage(new EllisonLanguage()) | |||
There was a problem hiding this comment.
I'm not sure whether it should be added by default if the required package is opt-in. However, let's keep it like this for now, and we'll see whether it gives any problems :)
|
|
||
| return $sentence; | ||
| } | ||
| } |
|
@assertchris I made a couple of small changes. The most important one is that I removed the addition of Maybe we should make it configurable on the |
|
Oh also, I added some docs about this: https://tempest.stitcher.io/highlight/04-optin |
With the test server running: http://localhost:8080/?target=targets/ellison.md&wrap=1&stylesheet=stylesheets/ellison.css