Add JWT API key authentication to YOLOv4 #65
Merged
+208
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milank94
reviewed
Jan 3, 2025
milank94
approved these changes
Jan 3, 2025
There was a problem hiding this comment.
Updates look good. Some reorganization could be done to consolidate some of the common utils such as jwt_util.py with the other models.
@sbennettTT please ensure that these updates are propagated to AI Playground
sbennettTT
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #64 by adding JWT API key authentication to the main inference endpoint. Authentication is performed similarly to the other inference servers, where the
Authenticationheader is sent with a Bearer token.Tests
Tests were added to
tt-metal-yolov4/tests/test_inference_api.pyto demonstrate valid and invalid API requests.