Changing how we setup simulator. #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
broskoTT
approved these changes
Dec 31, 2024
pjanevskiTT
approved these changes
Jan 3, 2025
pjanevskiTT
approved these changes
Jan 15, 2025
tt-vjovanovic
added a commit
to tenstorrent/tt-metal
that referenced
this pull request
Jan 21, 2025
Previously, `tt_SimulationDevice` needed to be setup with two arguments: 1. Constructor argument with soc descriptor path. 2. Environment variable that points to simulator run script. Change in `tt_SimulationDevice` now requires only one argument, path to directory that contains all necessary files for simulator to run. That directory contains `soc_descriptor.yaml`, `run.sh` script and simulator application. This PR also removes need for two environment variables (`TT_METAL_SIMULATOR_EN` and `TT_REMOTE_EXE`) and replaces them with single `TT_METAL_SIMULATOR` variable that contains path to simulator build directory. In the future, when tt-metal is built only once for all architectures, this would mean that one would setup `TT_METAL_SIMULATOR` environment variable that point to simulator directory and would run it against architecture that is compiled in that directory. Related PRs: - [UMD simulators](https://yyz-gitlab.local.tenstorrent.com/tenstorrent/tt-metal/-/merge_requests/15) - [UMD](tenstorrent/tt-umd#449)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
tt_SimulationDeviceneeded to be setup with two arguments:Change in
tt_SimulationDevicenow requires only one argument, path to directory that contains all necessary files for simulator to run. That directory containssoc_descriptor.yaml,run.shscript and simulator application.Related PRs:
Manual testing:
Checkout tt-metal repository branch
vjovanovic/umd_simulatorsand built it.Checkout UMD simulators repository branch
vjovanovic/umd_simulators) and follow either VCS or versim readme.