feat: Support http respond headers for ALB listeners #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekirmayer
changed the title
bryantbiggs
reviewed
Jan 17, 2025
| load_balancer_arn = aws_lb.this[0].arn | ||
| port = try(each.value.port, var.default_port) | ||
| protocol = try(each.value.protocol, var.default_protocol) | ||
| ssl_policy = contains(["HTTPS", "TLS"], try(each.value.protocol, var.default_protocol)) ? try(each.value.ssl_policy, "ELBSecurityPolicy-TLS13-1-2-Res-2021-06") : try(each.value.ssl_policy, null) | ||
| tcp_idle_timeout_seconds = try(each.value.tcp_idle_timeout_seconds, null) | ||
| tags = merge(local.tags, try(each.value.tags, {})) | ||
|
|
||
| lifecycle { |
bryantbiggs
reviewed
Jan 17, 2025
| } | ||
|
|
||
| resource "terraform_data" "listeaner_replacement_trigger" { |
There was a problem hiding this comment.
@bryantbiggs the provider doesnt update in place the values. It update only on create/recreate the listener.
There was a problem hiding this comment.
I'm not seeing that reflected in the implementation - it is checking for updates hashicorp/terraform-provider-aws#40736
if what you are saying is true, the provider should specify ForceNew: true - we are not going to handle that here
There was a problem hiding this comment.
NP, i will wait for a fix hashicorp/terraform-provider-aws#40986
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for HTTP Respond headers.
Allow setting each value.
Create a lifecycle trigger as the provider will not update the value in place.
Motivation and Context
Support #397
Breaking Changes
No
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request