Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows CI by pinning cmake version to 3.28.x #450

Closed

Conversation

Levi-Armstrong
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.65%. Comparing base (98c2a3a) to head (0c90c27).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #450   +/-   ##
=======================================
  Coverage   85.65%   85.65%           
=======================================
  Files         229      229           
  Lines       15238    15238           
=======================================
  Hits        13052    13052           
  Misses       2186     2186           

@Levi-Armstrong
Copy link
Contributor Author

@johnwason Do you know how to resolve the windows build error unresolved external symbol _Thrd_sleep_for.

@johnwason
Copy link
Contributor

I will take a look

@johnwason
Copy link
Contributor

@Levi-Armstrong you need to use the cmake fix for Mac OS as well since that uses vcpkg, and apparently it is in compatible with the latest cmake version.

@johnwason
Copy link
Contributor

I found a syntax error report:

 D:\a\tesseract_planning\tesseract_planning\upstream_ws\install\tesseract_common\include\tesseract_common/kinematic_limits.h(147): error C2059: syntax error: '('

@Levi-Armstrong
Copy link
Contributor Author

@johnwason I fixed the kinematics error, but do you know how to solve the current issue?

@johnwason
Copy link
Contributor

I guess this was fixed by cmake. Closing

@johnwason johnwason closed this Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants