Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove env_state from planning request #547

Conversation

Levi-Armstrong
Copy link
Contributor

@Levi-Armstrong Levi-Armstrong commented Dec 14, 2024

Having the env_state in the request introduces confusion on if the actual environment objects state matches this. This is removed and you should get the state from the environment object if needed.

Copy link

codecov bot commented Dec 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.71%. Comparing base (ad73309) to head (dfaeddb).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #547      +/-   ##
==========================================
- Coverage   78.84%   78.71%   -0.13%     
==========================================
  Files         251      251              
  Lines       14833    14738      -95     
==========================================
- Hits        11695    11601      -94     
+ Misses       3138     3137       -1     

see 13 files with indirect coverage changes

@Levi-Armstrong Levi-Armstrong merged commit 12faec5 into tesseract-robotics:master Dec 14, 2024
11 of 17 checks passed
@Levi-Armstrong Levi-Armstrong deleted the feature/remove-env-state-from-planning-request branch December 14, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant