<ComparisonTable>, <FAQ>, <Search> tweaks
#1927
Conversation
🦋 Changeset detectedLatest commit: ac86875 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
📚 Storybook DeploymentThe latest changes are available as preview in: https://833bd4b8.the-guild-docs-storybook.pages.dev |
dimaMachina
changed the title
<ComparisonTable>, <FAQ>, <Search> tweks
dimaMachina
changed the title
<ComparisonTable>, <FAQ>, <Search> tweks<ComparisonTable>, <FAQ>, <Search> tweaks
|
|
||
| useEffect(() => { | ||
| const html = document.querySelector('html')!; | ||
| const path = pathname.replace('/graphql/hive', '/'); |
There was a problem hiding this comment.
Should this always be /graphql/hive?
| {cloneElement(children, { | ||
| components: { | ||
| a, | ||
| h2, |
There was a problem hiding this comment.
This can't be done with a provider in Server Components world, right?
There was a problem hiding this comment.
yes, here is code from Yoga how it looks like, FAQ is mdx
| return <td className={cn(cellStyle, className)} {...props} />; | ||
| }; | ||
|
|
||
| export const ComparisonTable = Object.assign(Table, { |
There was a problem hiding this comment.
I think we could
import { Table } from "@theguild/components"| export const ComparisonTable = Object.assign(Table, { | |
| export const Table = Object.assign(_Table, { |
It doesn't really have to be a comparison table. It is one in Mesh, maybe in Yoga too, but I think the styles work for every table.
There was a problem hiding this comment.
in components <Table> component already reexported from Nextra
docs/packages/components/src/index.ts
Line 10 in e60c4c6
| const html = document.querySelector('html')!; | ||
| const path = pathname.replace('/graphql/hive', '/'); | ||
|
|
||
| if (faqPages.includes(path) && !html.hasAttribute('itemscope')) { |
There was a problem hiding this comment.
Like I mentioned on Slack, I doubt this check is needed.
| @@ -83,7 +85,7 @@ export function HiveNavigation({ | |||
| }, | |||
| ], | |||
| developerMenu, | |||
| searchProps, | |||
| search = <Search />, | |||
There was a problem hiding this comment.
You moved the styles here to a .css file, right?
There was a problem hiding this comment.
yes, because in Yoga I use <VersionnedSearch> search which passes Pagefind's filters
So I will avoid copy-pasting x100 characters className
No description provided.