Cancel-able requests #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added correct setting of "authenticationState" parameter to reflect state Revised OAuth data parsing to better handle unexpected responses Added support for POST queries with application/x-www-form-urlencoded mime types Added class method on MPOAuthURLRequest to extract an OAuth Authorization header value from a parameter string, to integrate with other Twitter utilities via OAuth Echo
Conflicts: Source/Framework/MPOAuthURLRequest.m
…r use with OAuth Echo
|
Weird, I coulda swore I'd fixed this. Did you pull any of the later changes I'd made or is this on the previous version of the code that you had? |
|
Oh, really? There's a chance I'm using it wrong! Is there another way to interrupt requests? Yep, I pulled the latest stuff. |
|
Yea, you're right, you did. I guarded against the crash at some point, but no I did not add the ability to cancel the load request entirely so I'll certainly merge that in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that if you perform requests asynchronously, but you release the delegate before completion (e.g. close the view controller that's asynchronously loading the name of the logged-in twitter user), you'll get a crash when the nonexistent delegate is messaged.
SHA: 973a8ff makes MPOAuthAPI return the request loaders, and adds a -cancel method to MPOAuthAPIRequestLoader so that it's possible to cancel requests.
Apologies for the other changes in this pull request, which you've already looked at - I can't seem to exclude them from the pull request.