Skip to content

Commit

Permalink
Remove all references to v1 (#10248)
Browse files Browse the repository at this point in the history
* remove v1 controller actions

* rename scopes and remove deleted?

* delete registrations.js

* remove old columns

* remove old views

* adjust validation

* remove old registration controller specs

* fix another validation

* fix new_or_deleted?

* delete old frontend specs

* rename last occurences to cancelled?

* remove recompute_timestamp

* remove all references to accepted_at

* remove all references to deleted_at

* remove :create from before action

* remove :destroy from before action

* bring back export csv until we decide what to do with it

* add back registration_from_params

* fix test copy paste whoopsie

* change all i18n -> I18n so the matcher can see it

* delete char counter.js

* remove unused keys

* added // i18n-tasks-use for setMessage

* undo merge whoopsie

* fix last two keys

* put back some keys

* include both // i18n-tasks-use t('registrations.errors.exceeds_event_limit')

* actually use the registrations.registered_with_account_html string instead of hardcoding it

* add Messages back into Payment Step

* add confirmation dialogue to refund

* fix last unused keys

* remove empty catch

* refactor if donation is higher than registration fee check

* add back series_registrations and non competing string with TODOs

* another en merge error

* add refund strings back

* internationalize subtotal

* remove migration

* add back to database dumper

* remove all references to registration_version

* remove event_icons
  • Loading branch information
FinnIckler authored Dec 9, 2024
1 parent 1f325fe commit 69475da
Show file tree
Hide file tree
Showing 65 changed files with 306 additions and 2,481 deletions.
13 changes: 0 additions & 13 deletions app/assets/javascripts/char-counter.js

This file was deleted.

84 changes: 0 additions & 84 deletions app/assets/javascripts/registrations.js

This file was deleted.

2 changes: 1 addition & 1 deletion app/controllers/api/v0/user_roles_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ def create
user = User.find(user_id)
ban_reason = params[:banReason]
scope = params[:scope]
upcoming_comps_for_user = user.competitions_registered_for.not_over.merge(Registration.not_deleted).pluck(:id)
upcoming_comps_for_user = user.competitions_registered_for.not_over.merge(Registration.not_cancelled).pluck(:id)
unless upcoming_comps_for_user.empty?
return render status: :unprocessable_entity, json: {
error: "The user has upcoming competitions: #{upcoming_comps_for_user.join(', ')}. Before banning the user, make sure their registrations are deleted.",
Expand Down
Loading

0 comments on commit 69475da

Please sign in to comment.