Skip to content

Commit

Permalink
fix(): eslint setup
Browse files Browse the repository at this point in the history
  • Loading branch information
tiagosiebler committed Nov 8, 2024
1 parent f685dc1 commit 7023b0a
Show file tree
Hide file tree
Showing 6 changed files with 106 additions and 91 deletions.
84 changes: 84 additions & 0 deletions .eslintrc.cjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,84 @@
module.exports = {
parser: '@typescript-eslint/parser',
parserOptions: {
project: 'tsconfig.linting.json',
tsconfigRootDir: __dirname,
sourceType: 'module',
},
plugins: [
'@typescript-eslint/eslint-plugin',
'simple-import-sort',
// 'require-extensions',
],
extends: [
'plugin:@typescript-eslint/recommended',
'plugin:prettier/recommended',
// 'plugin:require-extensions/recommended',
],
root: true,
env: {
node: true,
jest: true,
},
ignorePatterns: ['.eslintrc.js'],
rules: {
'@typescript-eslint/await-thenable': 'error',
'@typescript-eslint/dot-notation': 'off',
'@typescript-eslint/no-unused-vars': 'warn',

'@typescript-eslint/no-unused-expressions': 'error',
'@typescript-eslint/no-var-requires': 'error',
'@typescript-eslint/prefer-namespace-keyword': 'error',

'@typescript-eslint/no-explicit-any': 'error',
'@typescript-eslint/no-floating-promises': 'off',
'@typescript-eslint/no-inferrable-types': 'off',
'@typescript-eslint/promise-function-async': 'off',
'@typescript-eslint/no-use-before-define': 'off',
'@typescript-eslint/no-non-null-assertion': 'off',
'@typescript-eslint/ban-types': 'off',
'@typescript-eslint/ban-ts-comment': 'off',

'no-dupe-class-members': 'off',
'no-param-reassign': ['error'],
'array-bracket-spacing': ['error', 'never'],
indent: ['off'],
'linebreak-style': ['error', 'unix'],
'lines-between-class-members': ['warn', 'always'],
semi: 'off',
'@typescript-eslint/semi': ['error'],
'new-cap': 'off',
'no-console': 'off',
'no-debugger': 'off',
'no-mixed-spaces-and-tabs': 2,
'no-use-before-define': [2, 'nofunc'],
'no-unreachable': ['warn'],
'no-unused-vars': ['warn'],
'no-extra-parens': ['off'],
'no-mixed-operators': ['off'],
quotes: [2, 'single', 'avoid-escape'],
'block-scoped-var': 2,
'brace-style': [2, '1tbs', { allowSingleLine: true }],
'computed-property-spacing': [2, 'never'],
'keyword-spacing': 2,
'space-unary-ops': 2,
'sort-imports': [
'error',
{
ignoreCase: false,
ignoreDeclarationSort: true,
ignoreMemberSort: false,
memberSyntaxSortOrder: ['none', 'all', 'multiple', 'single'],
allowSeparatedGroups: false,
},
],
'max-len': ['warn', { code: 140 }],

// newer rules
'@typescript-eslint/interface-name-prefix': 'off',
'@typescript-eslint/explicit-function-return-type': 'off',
'@typescript-eslint/explicit-module-boundary-types': 'off',
'simple-import-sort/imports': 'error',
'simple-import-sort/exports': 'error',
},
};
86 changes: 0 additions & 86 deletions .eslintrc.json

This file was deleted.

4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions test/response.util.ts
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export function successEmptyResponseObjectV3() {
export function errorResponseObject(
result: null | any = null,
ret_code: number,
ret_msg: string
ret_msg: string,
) {
return {
result,
Expand All @@ -58,7 +58,7 @@ export function errorResponseObject(

export function errorResponseObjectV3(
result: null | any = null,
retCode: number
retCode: number,
) {
return {
result,
Expand Down
2 changes: 1 addition & 1 deletion test/v5/private.read.test.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { API_ERROR_CODE, RestClientV5 } from '../../src';
import { successResponseObjectV3 } from '../response.util';
import { getTestProxy } from '../proxy.util';
import { successResponseObjectV3 } from '../response.util';

describe('Private READ V5 REST API Endpoints', () => {
const API_KEY = process.env.API_KEY_COM;
Expand Down
17 changes: 17 additions & 0 deletions tsconfig.linting.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
{
"extends": "./tsconfig.json",
"compilerOptions": {
"module": "commonjs",
// "outDir": "dist/cjs",
"target": "esnext",
"rootDir": "../",
"allowJs": true
},
"include": [
"src/**/*.*",
"test/**/*.*",
"examples/**/*.*",
".eslintrc.cjs",
"jest.config.ts"
]
}

0 comments on commit 7023b0a

Please sign in to comment.