Corrected shouldBeConsumedByChild logic for vertical scrolling; fixes m…

…dbootstrap#139
tibineagu · Jul 12, 2022 · 77471be · 77471be
1 parent c3354c0
commit 77471be
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/src/handlers/mouse-wheel.js b/src/handlers/mouse-wheel.js
@@ -81,9 +81,12 @@ export default function(i) {
       if (deltaY && style.overflowY.match(/(scroll|auto)/)) {
         const maxScrollTop = cursor.scrollHeight - cursor.clientHeight;
         if (maxScrollTop > 0) {
+          // Note: negative deltaY means scrolling down
           if (
-            (cursor.scrollTop > 0 && deltaY < 0) ||
-            (cursor.scrollTop < maxScrollTop && deltaY > 0)
+            // Already scrolled vertically, user is scrolling up
+            (cursor.scrollTop > 0 && deltaY > 0) ||
+            // Hasn't reached bottom, user is scrolling down
+            (cursor.scrollTop < maxScrollTop && deltaY < 0)
           ) {
             return true;
           }