Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was searching the code what could cause this error
and I found one place in our ClusterRenderer in
getPositiom()
that could returnnull
for a cluster. BUT with Android Studio I saw that it actually is marked as@NonNull
. So I've added that in our override and in rare cases where it was returningnull
before (when theproxy
is gone already but it still tries to create a cluster) it now returns LatLng(0,0). From my understanding that should only be the case when you e.g. close a window and it is clustering items and they are being removed.Also added another null check for
tiMarker
before adding a cluster item.I've tested it with annotations at position 0,0 and they are displayed and also clustered. So in a rare case when you want to add something at 0,0 it still is displayed 😄
I couldn't verify if this fixes that error because it happens very very rarely. But using this for a couple of days now and no crash so far 🤞
ti.map-android-5.6.2.zip