Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logic to catch single named logical expressions #7113

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add logic to catch single named logical expressions #7113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions R/filter.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,11 +154,11 @@ check_filter <- function(dots, error_call = caller_env()) {

for (i in which(named)) {
quo <- dots[[i]]

# only allow named logical vectors, anything else
# is suspicious
expr <- quo_get_expr(quo)
if (!is.logical(expr)) {

# Allow named logical vectors but catch bare
# logical values and anything else
if (!is.logical(expr) || (is.logical(expr) && length(expr) == 1)) {
name <- names(dots)[i]
bullets <- c(
"We detected a named input.",
Expand Down
Loading