-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: unified graph captions. #410
Merged
Merged
Changes from 4 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
466e776
Unified graph captions.
emori-ctc e82a7ee
Unified conditional branching of graph captions.
emori-ctc d9653f2
Fixed flake8 errors.
emori-ctc 6493828
Point corrected.
emori-ctc d692ff0
Corrected string notation.
emori-ctc a600e5c
Corrected string notation.
emori-ctc f98ce94
Corrected string notation.
emori-ctc 95d724e
Corrected the points pointed out.
emori-ctc b6464f5
Corrected caption.
emori-ctc e0ec807
Corrected caption.
emori-ctc f2bacf1
Merge branch 'tier4:main' into unification_caption
emori-ctc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -214,7 +214,8 @@ def histogram( | |||||
raise NotImplementedError() | ||||||
|
||||||
plot: Figure = Figure( | ||||||
title=data_type if case is None else f'{data_type} --- {case} case ---', | ||||||
title=f'Histogram of {data_type}' | ||||||
if case is None else f'histogram of {data_type} --- {case} case ---', | ||||||
x_axis_label=x_label, y_axis_label='Probability', plot_width=800 | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
) | ||||||
|
||||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -59,10 +59,11 @@ def create_figure(self) -> Figure: | |||||
# # get stacked bar data | ||||||
data: dict[str, list[int | float]] | ||||||
y_labels: list[str] = [] | ||||||
y_axis_label = 'latency [ms]' | ||||||
caption = 'latency' | ||||||
y_axis_label = caption + ' [ms]' | ||||||
target_objects = self._metrics.target_objects | ||||||
data, y_labels = self._metrics.to_stacked_bar_data() | ||||||
title: str = f"Stacked bar of '{getattr(target_objects, 'path_name')}'" | ||||||
title: str = f'Stacked bar of response Time --- {self._case} case ---' | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not fixed.
Suggested change
|
||||||
|
||||||
fig = init_figure(title, self._ywheel_zoom, self._xaxis_type, y_axis_label) | ||||||
frame_min = data['start time'][0] | ||||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.