Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support for mypy>1 #425

Merged
merged 8 commits into from
Nov 27, 2023
Merged

fix: support for mypy>1 #425

merged 8 commits into from
Nov 27, 2023

Conversation

rokamu623
Copy link
Contributor

@rokamu623 rokamu623 commented Nov 8, 2023 •
edited by xygyo77
Loading

Description

Updated mypy version to v1.x and corrected a coding rule error that occurred as a result.

Related links

Jira: https://tier4.atlassian.net/browse/RT2-944

Notes for reviewers

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR has been properly tested.
  • The PR has been reviewed.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • (Optional) The PR has been properly tested with CARET_report verification.
  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@rokamu623 rokamu623 self-assigned this Nov 8, 2023
@rokamu623 rokamu623 marked this pull request as ready for review November 20, 2023 23:47
bopeng-saitama
bopeng-saitama approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@bopeng-saitama bopeng-saitama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot from 2023-11-22 14-46-44
Screenshot from 2023-11-22 14-46-59
LGTM

@isp-uetsuki isp-uetsuki requested review from xygyo77 and removed request for isp-uetsuki November 22, 2023 06:48
xygyo77
xygyo77 approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@xygyo77 xygyo77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
image
The pip list result was 0.981, but at run time, we confirmed that we were using v1.7.1 as follows.
image

Visualization image confirmation was also OK.
LGTM.

@rokamu623 rokamu623 changed the title fix: support for mypy v1.6.1 fix: support for mypy>1 Nov 27, 2023
@rokamu623 rokamu623 merged commit b248902 into tier4:main Nov 27, 2023
9 checks passed
isp-uetsuki added a commit to isp-uetsuki/CARET_analyze that referenced this pull request Dec 27, 2023
@isp-uetsuki
Revert "fix: support for mypy>1 (tier4#425)"
46851ec 
This reverts commit b248902.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bopeng-saitama bopeng-saitama bopeng-saitama approved these changes

@xygyo77 xygyo77 xygyo77 approved these changes

Assignees

@rokamu623 rokamu623

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rokamu623 @xygyo77 @bopeng-saitama