feat: jazzy support #542
feat: jazzy support #542
Conversation
|
In this PR, distribution is taken from an environment variable. This looks good at first glance, but there may be cases where the environment is not identical at the time of measurement and analysis. In this process, we want the distribution of the measurement environment to be acquired. In this case, we should get the information about the distribution from the trace data, and in fact the distribution is stored in |
|
Fixed to reference "distribution" stored in caret_init |
src/test/infra/lttng/test_lttng.py
Outdated
| 'distribution', | ||
| ['jazzy', 'iron'], | ||
| ) | ||
| def test_duplicated_events_entities_collector(self, mocker, distribution): |
There was a problem hiding this comment.
I only wanted jazzy to work, so iron was deleted
There was a problem hiding this comment.
Thanks for the correction. If the distribution is jazzy only, there is no need to use pytest.mark.paramatrize.
Could you remove prametrize and remove the if statement?
There was a problem hiding this comment.
Removed prametrize
Description
jazzy support
Related links
https://tier4.atlassian.net/browse/RT2-1803
Notes for reviewers
Pre-review checklist for the PR author
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.