Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed merge timestamp_key for nodes that get messages by take() on user code #545

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ymski
Copy link
Contributor

@ymski ymski commented Jan 7, 2025

Description

Fixed merge timestamp_key for nodes that get messages by take() on user code.

Related links

Notes for reviewers

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR has been properly tested.
  • The PR has been reviewed.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • (Optional) The PR has been properly tested with CARET_report verification.
  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@ymski ymski force-pushed the fix/remove_rmw_take_column branch from 3ca953c to 1b49739 Compare January 16, 2025 06:42
@ymski ymski changed the title fix: remove rmw_take column fix: fixed merge key for nodes that get messages by take() on user code Jan 16, 2025
@ymski ymski changed the title fix: fixed merge key for nodes that get messages by take() on user code fix: fixed merge timestamp_key for nodes that get messages by take() on user code Jan 16, 2025
@ymski ymski marked this pull request as ready for review January 16, 2025 07:12
@ymski ymski requested a review from xygyo77 January 16, 2025 07:14
ymski added 2 commits January 23, 2025 15:44
Signed-off-by: Koudai Yamasaki <[email protected]>
Signed-off-by: Koudai Yamasaki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant