Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: modified methods for multimethod v2. #546

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

ymski
Copy link
Contributor

@ymski ymski commented Jan 9, 2025

Description

Modification of methods that have been disabled since multimethod version 2.

Related links

Notes for reviewers

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR has been properly tested.
  • The PR has been reviewed.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • (Optional) The PR has been properly tested with CARET_report verification.
  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Koudai Yamasaki <[email protected]>
@ymski ymski marked this pull request as ready for review January 9, 2025 07:03
@ymski
Copy link
Contributor Author

ymski commented Jan 9, 2025

The following versions have been tested with pytest.

branch \ multimethod version 1.2 2.0
main(3ffd706) OK NG (625/635)
This PR OK OK

Signed-off-by: Koudai Yamasaki <[email protected]>
@ymski ymski requested a review from xygyo77 January 14, 2025 01:12
Copy link
Contributor

@xygyo77 xygyo77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

LGTM

@ymski ymski merged commit 9fb70d9 into tier4:main Jan 16, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants