Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cppcheck into ci #291

Merged
merged 28 commits into from
Jun 27, 2024
Merged

feat: add cppcheck into ci #291

merged 28 commits into from
Jun 27, 2024

Conversation

xygyo77
Copy link
Contributor

@xygyo77 xygyo77 commented Jun 20, 2024

Description

Add cppcheck to ci. At the same time, the correction of the indicated items in cppcheck is carried out and the cppcheck is set to its initial state.

Related links

https://tier4.atlassian.net/browse/RT2-1667

Notes for reviewers

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR has been properly tested.
  • The PR has been reviewed.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@xygyo77 xygyo77 requested a review from ymski June 20, 2024 06:42
xygyo77 and others added 20 commits June 20, 2024 18:07
Signed-off-by: ISP akm <[email protected]>
Signed-off-by: ISP akm <[email protected]>
Signed-off-by: ISP akm <[email protected]>
Signed-off-by: ISP akm <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.03%. Comparing base (75e1c3f) to head (30be6bb).
Report is 21 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #291       +/-   ##
===========================================
+ Coverage   25.02%   55.03%   +30.00%     
===========================================
  Files          58       28       -30     
  Lines        3321     2186     -1135     
  Branches     1085     1218      +133     
===========================================
+ Hits          831     1203      +372     
+ Misses       1756      702     -1054     
+ Partials      734      281      -453     
Flag Coverage Δ
differential 55.03% <100.00%> (?)
total ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ymski ymski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xygyo77 xygyo77 merged commit 8358563 into tier4:main Jun 27, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants