omnibus: scroller perf, devex enhancements #1197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This hook was originally extracted from the Unread banner and then reused in the Scroller; now pulling it back in to the Banner
This changes the localStorage key used to persist the banner notification dimissal to be consistent with the rest of the values we track.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
First, prioritize the most recently viewed channel; then batch fetch the remaining channels. Also, consolidate recentChannel tracking into a hook.
Since we pre-fetch all messages from all channels, this change decreases the initial page fetch size to reduce load on the backend, and to render the page sooner. Then for future page fetches, it uses a much higher number, to reduce subsequent fetches as the user backscrolls. In a future commit, we will hook into the virtuoso scroll seek configuration; if the user is scrolling above a certain threshold velocity, we will fetch even more messages in anticipation of them going deep in the backscroll.
tomholford
changed the title
patosullivan
approved these changes
Nov 18, 2022
| await fetchChannel(recentChannel); | ||
| } | ||
|
|
||
| // defer the rest, in batches |
arthyn
requested changes
Nov 18, 2022
|
So I haven't been able to capture this on camera, but in either watercooler or urbit app dev, on a fresh reload, if you scroll up as soon as you see messages and then scroll up again once the second set of messages load, sometimes you get stuck in like a purgatory of sorts where messages are almost all missing and going either up or down scrolls in the wrong direction. Other than that, it seems like scrolling backwards now gets stuck more often than before. |
|
@arthyn Okay thanks, will look into this |
sidebar: recent sorting
As luck would have it, an issue that I was struggling with on mobile has been fixed in a recent update: petyosi/react-virtuoso#788 Went through the list of breaking changes and confirmed we are not affected.
arthyn
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This addresses #1187. It also includes additional performance enhancements and devex tweaks.
Changes
react-virtuosolast.briefto sort by recent insteadreact-virtuosofrom 2.19.0 --> 3.1.4 to fix a scroller bug on iOS Chrome