-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2.0.x - v2.0.5 - Added compatibility framework support for v4.5 - v4.8 / Core 2.2 & 3.0 / Standard 2.0 & 2.1 #34
base: master
Are you sure you want to change the base?
Conversation
Updated to support .NET Framework v4.7. Consolidated various redundant code statements and expressions. Repacked for multi-frameworks. Updated versioning.
Replaced string formatting with string interpolation.
db63f43
to
3c335d1
Compare
@Latency Thanks for this, I'd take a look. In the meantime let's keep all indentations Allman Style https://en.wikipedia.org/wiki/Indent_style#Allman_style |
Do I need to repack to code-format or?
You pull it.. and then check it back in on your end if you have Allman code format styles setup on your end.
I use K&R here. Have been for 20+ yrs since I came from a Linux/UNIX background.
|
@Latency it should be quite straightforward to change. If you're using any Visual Studio product you can format with some shortcut keys. Allman style is a C# best practice |
@Latency still working on this? |
Yes, I will work on it today. Sorry.. I have been busy.
|
Updated <Author> tag in manifest.
Went through and updated the merge conflicts. There are some concerns with the MSBuild automation code I had put in for creating artifacts directory and NuGet packages in the distro. I managed to create a version / tag release for v1.2.1 w/ NuGet binaries on my forked repo, but ultimately, I feel this should be merged as well. Thoughts, comments, feedback? |
Bah, somebody is making modifications to 'useHistory'. Is this new code or stale? Looking at the timestamps, I can't see any changes for +5 mo. Can you tell me what is going on here? I thought I had the latest check-in from the tracking history. |
Thank you @tonerdo for updating my latest build configurations in my previous PR!!! Release Notes v2.0.1:Fixed unit tests compilation errors and missing/invalid tab completion parameters. Added support for .NET Framework v4.5 / v4.6.2 & Standard 1.3 for backwards compatibility. |
Changed version.
7758758
to
89c02da
Compare
This is bothering to me. I tried to run unit tests for XUnit (original) and switched it out to NUnit (current) which yield the identical results. The problem is that under release test, the Console handle is not being set. When Console2 class goes to make the Console.X calls... it throws. I tried setting the stream in to it and during [SetUp] of the test, but it still throws. Not sure what's going on here. If anybody cares to look into it further, I will restore the test.ps1 for Appveyor. This is the new release. for the appveyor reason, I decided to take out target support for Framework 4.8 and Standard 3.0. The next release I will put them in.. which will be latest and no code differences. |
4ad4868
to
ca0b062
Compare
@Latency I just cloned your master branch and ran the demo app and history fails. You don't have "Issues" enabled on your fork so I thought I would respond here. You can see screencast of the error here. https://www.screencast.com/t/YiIZ01FU7Dgs |
Issues now enabled. I will take a look into it. |
History fixed! Let me know if you experience any more issues. |
I was wondering the same thing! @tonerdo needs to pull it. He is not letting me take it over in his absence. Still trying to get permissions. You should be able to download it manually off my build, but it won't be pushed up on NuGet.org yet since he has access to that account too. |
Refactored static ReadLine class to a true singleton. Changed unit tests to use NUnit instead of XUnit. Fixed Ctrl+C issue tonerdo#59 (Add option to return CTRL+C) Updated version.
Refactored static ReadLine class to a true singleton. Changed unit tests to use NUnit instead of XUnit. Fixed Ctrl+C issue tonerdo#59 (Add option to return CTRL+C) Updated version.
be27915
to
ac6c798
Compare
Release Notes v2.1.3:Known GitHub issue with appveyor not supporting targets for .NET Core 3.0 yet. |
Refactored static ReadLine class to a true singleton. Changed unit tests to use NUnit instead of XUnit. Fixed Ctrl+C issue tonerdo#59 (Add option to return CTRL+C) Updated version.
Updated to support .NET Core 2.1.
Updated to support .NET Standard v2.0.
Updated to support .NET Framework v4.7.2.
Consolidated redundant code and expressions.
Repacked for multi-frameworks.
Updated versioning.
Updated test projects.
Signed assembly for GAC and other project integrations.