Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoComplete - Faster tab completion #51

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

cobbr
Copy link

@cobbr cobbr commented Apr 5, 2019

I've made some changes that allows for faster tab completion by backspacing all the needed characters at once, as opposed to one at a time.

Prior to this change, I've noticed some issues with very slow tab completion, especially when using a readline project over an ssh connection. I think this addresses those issues.

This PR is similar to the goal of #45, but makes much smaller changes, and passes all unit tests.

Thanks so much for this project, hope this change is useful!

@Latency
Copy link

Latency commented Apr 8, 2019

I see what you did. I approve this change. Nice job!
Did you already run all the tests on it to validate the changes too?

@cobbr
Copy link
Author

cobbr commented Apr 8, 2019

@Latency Yep, all tests seem to be passing!

@Latency
Copy link

Latency commented Apr 8, 2019

Can you take a look at Ctrl+W .. It looks like you could do your magic there too.

Thoughts?

I have gone ahead and merged your efforts into my build. Although my PR is outstanding for about a year, it is the latest up to date since Torondo is busy.

@cobbr
Copy link
Author

cobbr commented Apr 8, 2019

@Latency Oh sweet, I'll check out your fork. I can look into Ctrl+W too

@Latency
Copy link

Latency commented Apr 8, 2019

What I do is configure Remote Repositories to include whomever and that way you can track their changes to be merged into your branch.

It is showing that mine is the latest branch. I am working on getting PR admin access... so we can merge it to master.

I updated target framework versions today to latest as well. I believe I have a .nupkg port ready for download on my repository under 'artifacts'.

You can configure your Tools -> NuGet Package Manager -> Package Manager Settings to include the location of the newly downloaded file so it can find it in NuGet to be added rather than, or in conjunction to, the NuGet,org for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants