Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove grpc rpc #414

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Remove grpc rpc #414

wants to merge 4 commits into from

Conversation

felipejfc
Copy link
Contributor

Remove GRPC RPC model as we will focus on NATS support only. It has proven rock stable and easier to manage in productive loads. It also enabled servers on different clouds/clusters to talk to each other given that all of them can talk to the NATS cluster for dispatching messages.

For the ones who liked GRPC more, both RPC server and Client in pitaya have interfaces and a method for you to replace the default one with your own implementation. So you can basically copy the grpc files to inside your project and use it.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10187728597

Details

  • 7 of 35 (20.0%) changed or added relevant lines in 2 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.6%) to 58.588%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/docgenerator/descriptors.go 7 9 77.78%
pkg/client/protoclient.go 0 26 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/app.go 3 66.15%
Totals Coverage Status
Change from base Build 10150830854: -0.6%
Covered Lines: 4673
Relevant Lines: 7976

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants