feat: locally overlay-kit #102
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d5f348b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Copilot reviewed 5 out of 9 changed files in this pull request and generated no comments.
Files not reviewed (4)
- packages/src/context/provider.tsx: Evaluated as low risk
- packages/src/context/use-sync-overlay-store.ts: Evaluated as low risk
- packages/src/utils/index.ts: Evaluated as low risk
- packages/src/event.ts: Evaluated as low risk
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #102 +/- ##
==========================================
- Coverage 81.48% 81.31% -0.17%
==========================================
Files 11 13 +2
Lines 243 273 +30
Branches 49 54 +5
==========================================
+ Hits 198 222 +24
- Misses 43 47 +4
- Partials 2 4 +2
|
This reverts commit a3a804c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue: Fixes # (issue_number)
This PR modifies the overlay-kit, which was previously available only globally, to be usable in local environments.
To achieve this, components like
OverlayProviderhave been adapted into acreateOverlayProviderformat, making them reusable locally.Users can now utilize the new function
experimental_createOverlayContext, which enables this local usage. However, since this function is experimental, caution is advised when using it.Changes
OverlayProviderand similar components intocreateOverlayProviderfor local use.experimental_createOverlayContext, allowing local context creation for overlays.Motivation and Context
Previously, the overlay-kit could only be used globally, limiting flexibility in development.
This change enables developers to utilize overlay functionality in localized contexts, enhancing modularity and reusability.
How Has This Been Tested?
experimental_createOverlayContextfunction in local environments to verify its functionality.Screenshots (if appropriate):
example code
Types of changes
Checklist
Further Comments
Since
experimental_createOverlayContextis experimental, users should proceed with caution and monitor its behavior in various use cases.