Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support git commit --fixup=amend:<commit> and --fixup=reword:<commit> keymaps #2369

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

KSR-Yasuda
Copy link
Contributor

Besides the current keymap cf = git commit --fixup=<commit>,
support --fixup=amend:<commit> and --fixup=reword:<commit> as cfa and cfr.

Also added a keymap cff for the command of cf,
since the original keymap cf comes to wait for an extra key a or r till timeout.

@tpope
Copy link
Owner

tpope commented Jan 20, 2025

Please follow the precedent set by Magit.

@KSR-Yasuda
Copy link
Contributor Author

So, you mean this?

Then, the existing binding cA changes:
to be used for commit --edit --fixup=amend:<commit>;
but now commit --edit --squash=<commit>, that ought to be cn.

@tpope
Copy link
Owner

tpope commented Jan 20, 2025

Then, the existing binding cA changes:

I guess we should have a grace period that tells users about the change. I'll go ahead and do that.

tpope added a commit that referenced this pull request Jan 20, 2025
Following Magit's lead.

References: #2369
tpope added a commit that referenced this pull request Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants