Document BigQuery RPC settings #24638
Conversation
|
I think we should remove |
Yes, waiting feedback from your side @ebyhr on whether we should do this before proceeding with this PR. |
| used for gRPC communication. | ||
| - `1` | ||
| * - `bigquery.channel-pool.min-size` | ||
| - The absolute minimum size of the connection pool, also known as a channel |
There was a problem hiding this comment.
| - The absolute minimum size of the connection pool, also known as a channel | |
| - The minimum size of the connection pool, also known as a channel |
There was a problem hiding this comment.
Also ... size in what .. maybe better
The minimum number of connections in the connection pool, ...
| pool, used for gRPC communication. | ||
| - `1` | ||
| * - `bigquery.channel-pool.max-size` | ||
| - The absolute maximum size of the connection pool, also known as a channel |
There was a problem hiding this comment.
| - The absolute maximum size of the connection pool, also known as a channel | |
| - The maximum size of the connection pool, also known as a channel |
| @@ -177,6 +177,59 @@ a few caveats: | |||
| - Enable using Apache Arrow serialization when reading data from BigQuery. | |||
| Please read this [section](bigquery-arrow-serialization-support) before using this feature. | |||
| - `true` | |||
| * - `bigquery.channel-pool.initial-size` | |||
| - The initial size of the connection pool, also known as a channel pool, | |||
| used for gRPC communication. | |||
There was a problem hiding this comment.
do we explain gRPC and RPC somewhere earlier in the doc? If not .. we might want to .. or at least link to some external doc
| @@ -177,6 +177,59 @@ a few caveats: | |||
| - Enable using Apache Arrow serialization when reading data from BigQuery. | |||
| Please read this [section](bigquery-arrow-serialization-support) before using this feature. | |||
There was a problem hiding this comment.
Can you remove the "Please" here .. in a separate commit if you want
| - `1` | ||
| * - `bigquery.channel-pool.min-rpc-per-channel` | ||
| - Threshold to start scaling down the channel pool. | ||
| When the average of the maximum number of outstanding RPCs in a single |
There was a problem hiding this comment.
Can we simplify to
| When the average of the maximum number of outstanding RPCs in a single | |
| When the average of outstanding RPCs in a single |
| - The maximum number of retry attempts to perform for the RPC calls. | ||
| If this value is set to `0`, the logic will instead use the | ||
| `bigquery.rpc-timeout` configuration value to determine retries. | ||
| In the event that both the `bigquery.rpc-retries` and |
| In the event that both the `bigquery.rpc-retries` and | ||
| `bigquery.rpc-timeout` values are both `0`, the logic will not retry. | ||
| If this value is positive, and the number of attempts exceeds | ||
| `bigquery.rpc-retries` limit, the logic will give up retrying even if |
| * - `bigquery.rpc-timeout` | ||
| - Timeout [duration](prop-type-duration) on when the retries for the | ||
| RPC call should be given up completely. The higher the timeout, the | ||
| more retries can be attempted. If this value is `0s`, then |
There was a problem hiding this comment.
then the value from bigquery.rpc-retries is used.
| RPC call should be given up completely. The higher the timeout, the | ||
| more retries can be attempted. If this value is `0s`, then | ||
| the logic will instead use `bigquery.rpc-retries` to determine retries. | ||
| In the event that `bigquery.rpc-retries` and `bigquery.rpc-timeout` |
There was a problem hiding this comment.
Retry is deactivated when both .. and .. are 0.
| In the event that `bigquery.rpc-retries` and `bigquery.rpc-timeout` | ||
| values are both `0`, the logic will not retry. | ||
| If this value is positive, and the retry duration has reached the timeout | ||
| value, the logic will give up retrying even the number of attempts is |
There was a problem hiding this comment.
| value, the logic will give up retrying even the number of attempts is | |
| value, retries stop. |
Description
Documents the settings from the https://github.com/trinodb/trino/blob/29ffc6c1c7d93bbd22ccdccb98ba39a5fab1fd68/plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQueryRpcConfig.java config class.
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: