Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-132330 / 25.04 / Update TrueNAS Brand #11318

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

denysbutenko
Copy link
Member

@denysbutenko denysbutenko commented Jan 9, 2025

Changes:

  • Updated svg files related for TrueNAS logo
  • Used TrueNAS Community Edition for SCALE
  • Used TrueNAS Enterprise for SCALE Enterprise
  • Added ix-truenas-logo component
  • Updated favicons

Testing:

Check affected places for regressions on desktop and mobile.

Downstream

Affects Reasoning
Documentation New branding, all screenshots needs to be updated

@denysbutenko denysbutenko requested a review from a team as a code owner January 9, 2025 15:49
@denysbutenko denysbutenko requested review from RehanY147 and removed request for a team January 9, 2025 15:49
@bugclerk
Copy link
Contributor

bugclerk commented Jan 9, 2025

@bugclerk bugclerk changed the title Nas 132330 NAS-132330 / 25.04 / Nas 132330 Jan 9, 2025
@denysbutenko denysbutenko changed the title NAS-132330 / 25.04 / Nas 132330 NAS-132330 / 25.04 / Update TrueNAS Brand Jan 9, 2025
@denysbutenko denysbutenko requested a review from undsoft January 9, 2025 15:58
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 53.31%. Comparing base (0f70118) to head (332355f).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/app/modules/layout/topbar/topbar.component.ts 0.00% 5 Missing ⚠️
src/app/helpers/copyright-text.helper.ts 50.00% 3 Missing ⚠️
...ules/layout/admin-layout/admin-layout.component.ts 0.00% 2 Missing ⚠️
...yout/topbar/truenas-logo/truenas-logo.component.ts 97.77% 1 Missing ⚠️
src/app/store/system-info/system-info.selectors.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #11318       +/-   ##
===========================================
- Coverage   82.74%   53.31%   -29.44%     
===========================================
  Files        1654     1655        +1     
  Lines       59135    59182       +47     
  Branches     6218     6233       +15     
===========================================
- Hits        48932    31550    -17382     
- Misses      10203    27632    +17429     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logo in the sidebar is too large and not centered visually.
Also please update truenas-logo-mark and related icons and the favicon with the single box like the new logo.

src/app/helptext/about.ts Outdated Show resolved Hide resolved
@denysbutenko denysbutenko requested review from undsoft and removed request for RehanY147 January 14, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants