NAS-133538 / 25.04 / fromemail must be specified when setting up OAuth for Outlook Mail
#11334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
fromemail must be specified when setting up OAuth for Outlook Mailfromemail must be specified when setting up OAuth for Outlook Mail
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #11334 +/- ##
=======================================
Coverage 82.74% 82.75%
=======================================
Files 1654 1654
Lines 59135 59135
Branches 6218 6218
=======================================
+ Hits 48932 48935 +3
+ Misses 10203 10200 -3 ☔ View full report in Codecov by Sentry. |
undsoft
approved these changes
Jan 14, 2025
| return this.isSmtp | ||
| ? this.form.valid | ||
| : this.hasOauthAuthorization; | ||
| return !this.isSmtp ? this.hasOauthAuthorization && this.form.valid : this.form.valid; |
There was a problem hiding this comment.
Maybe just rewrite as:
if (!this.form.valid) {
return false;
}
return ...
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing:
See ticket.
Result:
Downstream