Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support passing KMS key to bucket encryption configuration #317

Merged
merged 8 commits into from
Jan 15, 2025

Conversation

esacteksab
Copy link
Contributor

This copies aws_s3_server_side_encryption_configuration from terraform-aws-s3-private-bucket here. This adds two supporting variables kms_master_key_id and bucket_key_enabled. As defined, this contiues to support AES256 as the default algorithm that the current module supports.

elb_log_prefixes is changed from a string to a list(string) as resources in an iam_policy_document expects resources to be a list. This mirrors nlb_log_prefixes and alb_log_refixes which are already list(string) types.

  • chore: remove unnecessary file
  • chore: pinning github action
  • chore: renovate renovate config
  • chore: ignore lock file
  • chore: pre-commit autoupdate
  • feat: pass KMS key to bucket encryption

@esacteksab esacteksab merged commit a1456da into main Jan 15, 2025
1 check passed
@esacteksab esacteksab deleted the barry-update-things branch January 15, 2025 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants