Code

Code style enforcing#95

Code

Merged

marenz2569 merged 168 commits intomastertud-zih-energy/FIRESTARTER:masterfrom code-style-enforcingtud-zih-energy/FIRESTARTER:code-style-enforcingCopy head branch name to clipboardDec 5, 2024

+9,618-8,273

Commits

Commits on Sep 19, 2024

• enable compile commands generation

  marenz2569

  committed
  f67729b

  Copy full SHA for f67729b

• add .clang-format file base on LLVM style

  marenz2569

  committed
  f24a0b2

  Copy full SHA for f24a0b2

• clang-format

  marenz2569

  committed
  9732bdb

  Copy full SHA for 9732bdb

• ignore clang-format in blame

  marenz2569

  committed
  f4fd0ec

  Copy full SHA for f4fd0ec

• add clang-format ci job

  marenz2569

  committed
  de5ffd6

  Copy full SHA for de5ffd6

• add .cache folder to gitignore

  marenz2569

  committed
  7473e5f

  Copy full SHA for 7473e5f

Commits on Sep 20, 2024

• add .clang-tidy

  marenz2569

  committed
  c513d31

  Copy full SHA for c513d31

Commits on Sep 24, 2024

• disable clang-tidy extension that causes crash

  marenz2569

  committed
  29df30a

  Copy full SHA for 29df30a

• add clang-tidy workflow

  marenz2569

  committed
  f3960af

  Copy full SHA for f3960af

• Merge remote-tracking branch 'origin/master' into code-style-enforcing

  marenz2569

  committed
  742712e

  Copy full SHA for 742712e

• first pass of clang-tidy for the header files

  marenz2569

  committed
  b79754e

  Copy full SHA for b79754e

Commits on Sep 27, 2024

• update .clang-tidy

  marenz2569

  committed
  37a8518

  Copy full SHA for 37a8518

• add an empty file as a workaround for clangd issue

  marenz2569

  committed
  90beb59

  Copy full SHA for 90beb59

• second pass of clang-tidy for the header files. use unique_ptr for the payload instead of raw pointers

  marenz2569

  committed
  ff6113b

  Copy full SHA for ff6113b

• clang-tidy workflow: add .clang-tidy file location

  marenz2569

  committed
  c33291f

  Copy full SHA for c33291f

• clang-tidy workflow: update .clang-tidy file location

  marenz2569

  committed
  a3b01b1

  Copy full SHA for a3b01b1

• clang-tidy workflow: add comment and rum build before clang-tidy

  marenz2569

  committed
  d53a107

  Copy full SHA for d53a107

• clang-tidy workflow: update fetch depth

  marenz2569

  committed
  fafd720

  Copy full SHA for fafd720

• clang-tidy workflow: clone with submodules

  marenz2569

  committed
  6e4c880

  Copy full SHA for 6e4c880

Commits on Oct 2, 2024

• first pass of clang-tidy for the source files

  marenz2569

  committed
  770b405

  Copy full SHA for 770b405

Commits on Oct 3, 2024

• clang-tidy: allow big functions

  marenz2569

  committed
  1d98664

  Copy full SHA for 1d98664

• use enum class for constants

  marenz2569

  committed
  5aa731a

  Copy full SHA for 5aa731a

• clang-tidy: disable checks in lib folder

  marenz2569

  committed
  334b872

  Copy full SHA for 334b872

Commits on Oct 4, 2024

• refactor cpp side memory management of the high-load function. remove lots of reinterpret_cast and pointer magic. refactor dump register code.

  marenz2569

  committed
  6b388f6

  Copy full SHA for 6b388f6

• fix divission by zero warning

  marenz2569

  committed
  3876411

  Copy full SHA for 3876411

Commits on Oct 5, 2024

• clang-tidy fixes. create struct for allocating whole cache lines. clean up memory management for the high-load routine.

  marenz2569

  committed
  ba43956

  Copy full SHA for ba43956

• clang-tidy fixes

  marenz2569

  committed
  962c0da

  Copy full SHA for 962c0da

• cleanup load worker thread

  marenz2569

  committed
  5e04c5d

  Copy full SHA for 5e04c5d

• refactor load worker data

  marenz2569

  committed
  43fd6cb

  Copy full SHA for 43fd6cb

• use std::chrono::microseconds instead of uint64_t

  marenz2569

  committed
  d608e98

  Copy full SHA for d608e98

• use throw instead of returns for Environment class

  marenz2569

  committed
  5583723

  Copy full SHA for 5583723

• clang-tidy fixes

  marenz2569

  committed
  8ba518a

  Copy full SHA for 8ba518a

Commits on Oct 6, 2024

• remove some ifdefs. clang-tidy fixes

  marenz2569

  committed
  e87ef3c

  Copy full SHA for e87ef3c

• remove more ifdefs

  marenz2569

  committed
  7208aeb

  Copy full SHA for 7208aeb

• remove more ifdefs

  marenz2569

  committed
  3f32f6f

  Copy full SHA for 3f32f6f

• remove more ifdefs

  marenz2569

  committed
  35a73b1

  Copy full SHA for 35a73b1

• remove more ifdefs

  marenz2569

  committed
  6fdcf47

  Copy full SHA for 6fdcf47

• remove more ifdefs

  marenz2569

  committed
  4da8714

  Copy full SHA for 4da8714

• remove more ifdefs

  marenz2569

  committed
  05ab312

  Copy full SHA for 05ab312

• fix mingw compatibility

  marenz2569

  committed
  f58bfd5

  Copy full SHA for f58bfd5

• fix some MSC errors

  marenz2569

  committed
  f0e9439

  Copy full SHA for f0e9439

Commits on Oct 7, 2024

• fix errors in MSC compile

  marenz2569

  committed
  230103d

  Copy full SHA for 230103d

• fix errors in MSC compile

  marenz2569

  committed
  bfc2167

  Copy full SHA for bfc2167

• add inline to functions define in the windows compat header

  marenz2569

  committed
  bc3e37d

  Copy full SHA for bc3e37d

• AlignedAlloc: try to fix infinite recursion in free function

  marenz2569

  committed
  4910835

  Copy full SHA for 4910835

• WindowsCompat: fix _mm_mfence compatibilty

  marenz2569

  committed
  6169843

  Copy full SHA for 6169843

• fix Firestarter.cpp includes

  marenz2569

  committed
  33fc035

  Copy full SHA for 33fc035

• WindowsCompat: fix _mm_mfence compatibilty

  marenz2569

  committed
  7799e06

  Copy full SHA for 7799e06

Commits on Oct 8, 2024

• WindowsCompat: fix _mm_mfence compatibilty

  marenz2569

  committed
  e7efd15

  Copy full SHA for e7efd15

• fix static build

  marenz2569

  committed
  c29ccf8

  Copy full SHA for c29ccf8

• fix get_current_dir_name in apple build

  marenz2569

  committed
  21c10be

  Copy full SHA for 21c10be

• fix get_current_dir_name in apple build

  marenz2569

  committed
  e8370bf

  Copy full SHA for e8370bf

Commits on Oct 16, 2024

• cleanup cuda and hip code

  marenz2569

  committed
  e196bf2

  Copy full SHA for e196bf2

• Cuda: rename accellSafeCall

  marenz2569

  committed
  eb0d6e5

  Copy full SHA for eb0d6e5

Commits on Oct 17, 2024

• fix some cuda compile errors

  marenz2569

  committed
  b961fb8

  Copy full SHA for b961fb8

• fix some cuda compile errors

  marenz2569

  committed
  0edf8d7

  Copy full SHA for 0edf8d7

• fix some cuda compile errors

  marenz2569

  committed
  4307b13

  Copy full SHA for 4307b13

Commits on Oct 18, 2024

• cuda/hip compat: replace some static_assert with assert to cope with less powerful static analysis of older clang/gcc versions

  marenz2569

  committed
  14786a3

  Copy full SHA for 14786a3

• ci: set cxx compiler correctly for openapi build

  marenz2569

  committed
  73f3d88

  Copy full SHA for 73f3d88

• windowscompat: remove inline

  marenz2569

  committed
  47fc326

  Copy full SHA for 47fc326

• remove compile error

  marenz2569

  committed
  0e4fea0

  Copy full SHA for 0e4fea0

• windows compat: remove anonymous namespace for __cpuid and _mm_mfence

  marenz2569

  committed
  a788273

  Copy full SHA for a788273

• windows compat: remove anonymous namespaces from header

  marenz2569

  committed
  5912cb4

  Copy full SHA for 5912cb4

• ci: do not fail fast in linux build

  marenz2569

  committed
  20b6360

  Copy full SHA for 20b6360

• windowscompat: use static inline

  marenz2569

  committed
  aefe54c

  Copy full SHA for aefe54c

• fix oneapi

  marenz2569

  committed
  99c03f9

  Copy full SHA for 99c03f9

• windows compat: efix compatibility with icx

  marenz2569

  committed
  c9d57c1

  Copy full SHA for c9d57c1

• remove warning

  marenz2569

  committed
  4b652fd

  Copy full SHA for 4b652fd

• Revert "ci: set cxx compiler correctly for openapi build"

  Show description for def3a9f
  marenz2569

  committed
  def3a9f

  Copy full SHA for def3a9f

• fix hip/cuda compat layer

  marenz2569

  committed
  8973ddf

  Copy full SHA for 8973ddf

• fix problem with metric interface and hip compile

  marenz2569

  committed
  b396920

  Copy full SHA for b396920

• windows compat: fix hip build

  marenz2569

  committed
  e3b01db

  Copy full SHA for e3b01db

• fix link errors with metric interface restructure

  marenz2569

  committed
  a2f6033

  Copy full SHA for a2f6033

• fix windows msc build

  marenz2569

  committed
  ddd4b5e

  Copy full SHA for ddd4b5e

• fix windows msc build

  marenz2569

  committed
  f8a3bc5

  Copy full SHA for f8a3bc5

Commits on Oct 19, 2024

• windows compat: add #pragma message to debug _mm_mfence compatibility

  marenz2569

  committed
  e2cba76

  Copy full SHA for e2cba76

• windows compat: add emmintrin.h header when compiling with clang.

  marenz2569

  committed
  78272ad

  Copy full SHA for 78272ad

• Revert "windows compat: add #pragma message to debug _mm_mfence compatibility"

  Show description for 30aceef
  marenz2569

  committed
  30aceef

  Copy full SHA for 30aceef

• windows compat: less compiler warnings

  marenz2569

  committed
  d62dc1a

  Copy full SHA for d62dc1a

• Revert "ci: do not fail fast in linux build"

  Show description for ddfc1ae
  marenz2569

  committed
  ddfc1ae

  Copy full SHA for ddfc1ae

• restructure rapl: add callback back in again

  marenz2569

  committed
  1fd90f4

  Copy full SHA for 1fd90f4

Commits on Oct 24, 2024

• cleanup cuda/hip and openapi code. add todo comments with links to their respective issues

  marenz2569

  committed
  6696817

  Copy full SHA for 6696817

• fix cuda compat layer

  marenz2569

  committed
  6b50a28

  Copy full SHA for 6b50a28

• remove redundant reinterpret cast

  marenz2569

  committed
  3e13ca0

  Copy full SHA for 3e13ca0

• fix cast in cuda compat malloc function

  marenz2569

  committed
  6e57460

  Copy full SHA for 6e57460

• fix cast in cuda compat malloc/free functions

  marenz2569

  committed
  a0591db

  Copy full SHA for a0591db

• fix oneapi refactor

  marenz2569

  committed
  0921c1f

  Copy full SHA for 0921c1f

• refactor oneapi code

  marenz2569

  committed
  a77e429

  Copy full SHA for a77e429

• refactor oneapi code

  marenz2569

  committed
  77fec86

  Copy full SHA for 77fec86

Commits on Oct 25, 2024

• add script to start clang-tidy

  marenz2569

  committed
  badd0fe

  Copy full SHA for badd0fe

• update clang-tidy ci action

  marenz2569

  committed
  5c8f6c3

  Copy full SHA for 5c8f6c3

• update todos

  marenz2569

  committed
  93512a5

  Copy full SHA for 93512a5

• run clang-tidy useing 2 cores

  marenz2569

  committed
  049d183

  Copy full SHA for 049d183

• clang-tidy: scramble files to reduce the runtime

  marenz2569

  committed
  dc5c9dc

  Copy full SHA for dc5c9dc

• ci: run build before executing clang-tidy

  marenz2569

  committed
  4db1a5b

  Copy full SHA for 4db1a5b

• clang-tidy start with shell

  marenz2569

  committed
  e6ae34d

  Copy full SHA for e6ae34d

• clang-tidy: launch processes in new python thread

  marenz2569

  committed
  4ae98e3

  Copy full SHA for 4ae98e3

• run clang-tidy ci with 4 cores

  marenz2569

  committed
  2c26deb

  Copy full SHA for 2c26deb

• clang-tidy: find the correct source files for the current build

  marenz2569

  committed
  077662a

  Copy full SHA for 077662a

• remove error message from cuda/hip compat header

  marenz2569

  committed
  ae95982

  Copy full SHA for ae95982

• reformat clang-tidy

  marenz2569

  committed
  25571c1

  Copy full SHA for 25571c1

• clang-tidy: use seed for shuffled files

  marenz2569

  committed
  b9b468e

  Copy full SHA for b9b468e

• clang-tidy: add check to ci action

  marenz2569

  committed
  219a262

  Copy full SHA for 219a262

• clang-tidy: set python unbuffered in ci action

  marenz2569

  committed
  5c4cb4c

  Copy full SHA for 5c4cb4c

Commits on Oct 26, 2024

• refactor config parser

  marenz2569

  committed
  d978ca9

  Copy full SHA for d978ca9

• reorder config fields

  marenz2569

  committed
  f774833

  Copy full SHA for f774833

• do not access moved object

  marenz2569

  committed
  954bb30

  Copy full SHA for 954bb30

• X86 payloads: remove using. fix deprecation warning.

  marenz2569

  committed
  f1f8828

  Copy full SHA for f1f8828

• remove unused variable

  marenz2569

  committed
  6a6e261

  Copy full SHA for 6a6e261

• thin out payload class

  marenz2569

  committed
  2443465

  Copy full SHA for 2443465

• remove protected member

  marenz2569

  committed
  48cc7a8

  Copy full SHA for 48cc7a8

• remove protected data members. fix clang-tidy warnings

  marenz2569

  committed
  0742466

  Copy full SHA for 0742466

• fix clang-tidy warnings

  marenz2569

  committed
  73ee17b

  Copy full SHA for 73ee17b

Commits on Oct 27, 2024

• remove warnings

  marenz2569

  committed
  bcd588b

  Copy full SHA for bcd588b

• fix string compare in default cpu frequency lookup

  marenz2569

  committed
  295e538

  Copy full SHA for 295e538

• fix more warnings

  marenz2569

  committed
  e7222db

  Copy full SHA for e7222db

• Perf: fix warnings

  marenz2569

  committed
  6f52af8

  Copy full SHA for 6f52af8

• rapl: fix warnings

  marenz2569

  committed
  c05f47b

  Copy full SHA for c05f47b

• DumpRegisterStruct: fix warnings

  marenz2569

  committed
  aac47aa

  Copy full SHA for aac47aa

• use shared ptr for payload. less clone(). make functions in payload private/protected.

  marenz2569

  committed
  ef90525

  Copy full SHA for ef90525

Commits on Oct 28, 2024

• remove warnings

  marenz2569

  committed
  d9b2979

  Copy full SHA for d9b2979

• remove clone from payload

  marenz2569

  committed
  ba314d7

  Copy full SHA for ba314d7

• fix build with gcc

  marenz2569

  committed
  0dbe9d2

  Copy full SHA for 0dbe9d2

• replace std::quick_exit with a custom thread safe exit function

  marenz2569

  committed
  041acfe

  Copy full SHA for 041acfe

• refactor PlatformConfig and settings for the Payload. remove more non owning memory.

  marenz2569

  committed
  54fd662

  Copy full SHA for 54fd662

Commits on Oct 29, 2024

• clang-tidy fixes

  marenz2569

  committed
  af06097

  Copy full SHA for af06097

• cleanup clang-tidy script

  marenz2569

  committed
  a6d9c3f

  Copy full SHA for a6d9c3f

• make Config and Topology private in Environment class

  marenz2569

  committed
  f8af514

  Copy full SHA for f8af514

Commits on Oct 30, 2024

• clang-tidy: fix warnings

  marenz2569

  committed
  738933f

  Copy full SHA for 738933f

• add todo note

  marenz2569

  committed
  a218aad

  Copy full SHA for a218aad

• clang-tidy: fix warnings

  marenz2569

  committed
  7362553

  Copy full SHA for 7362553

Commits on Oct 31, 2024

• clang-tidy fixes

  marenz2569

  committed
  6ad9537

  Copy full SHA for 6ad9537

Commits on Nov 2, 2024

• clang-tidy: disable warnings from asmjit

  marenz2569

  committed
  de5bc81

  Copy full SHA for de5bc81

• clang-tidy: fix issues in MeasurementWorker

  marenz2569

  committed
  7e0ee18

  Copy full SHA for 7e0ee18

Commits on Nov 3, 2024

• clang-tidy: fixes

  marenz2569

  committed
  42bfb04

  Copy full SHA for 42bfb04

Commits on Nov 4, 2024

• clang-tidy: nolint unnecessary warnings

  marenz2569

  committed
  ef3b634

  Copy full SHA for ef3b634

Commits on Nov 5, 2024

• add docstrings for cuda

  marenz2569

  committed
  d954fe9

  Copy full SHA for d954fe9

• move compiled payload into a new header. add docstrings for payload classes

  marenz2569

  committed
  523a1f4

  Copy full SHA for 523a1f4

• move functions for sequences of items into payloadsettings

  marenz2569

  committed
  ac82234

  Copy full SHA for ac82234

• add more documentation to the payload and platform

  marenz2569

  committed
  d5c0311

  Copy full SHA for d5c0311

Commits on Nov 6, 2024

• refactor payload. add docstrings

  marenz2569

  committed
  235e92b

  Copy full SHA for 235e92b

Commits on Nov 7, 2024

• add more docstrings

  marenz2569

  committed
  982e2ca

  Copy full SHA for 982e2ca

• docstrings

  marenz2569

  committed
  23ccb55

  Copy full SHA for 23ccb55

• add docstrings

  marenz2569

  committed
  5a301a3

  Copy full SHA for 5a301a3

• add docstrings

  marenz2569

  committed
  e72b010

  Copy full SHA for e72b010

• change log error to log warn to not abort on failed metric init

  marenz2569

  committed
  ad22452

  Copy full SHA for ad22452

Commits on Nov 8, 2024

• add docstrings for measurement and metrics

  marenz2569

  committed
  7498853

  Copy full SHA for 7498853

• fix refactor in rapl metric

  marenz2569

  committed
  eef129f

  Copy full SHA for eef129f

• rapl metric docstrings

  marenz2569

  committed
  bbe6f57

  Copy full SHA for bbe6f57

• remove unused return argument in watchdogworker

  marenz2569

  committed
  283ec47

  Copy full SHA for 283ec47

• add docstrings to OneAPI

  marenz2569

  committed
  dc6c80a

  Copy full SHA for dc6c80a

• doc strings and rename funtions in optimization

  marenz2569

  committed
  cfc2cf1

  Copy full SHA for cfc2cf1

• cleanup optimization worker. add docstrings

  marenz2569

  committed
  29168c2

  Copy full SHA for 29168c2

• ci: remove GHC artifacts to make more space for the rocm build

  marenz2569

  committed
  1690ec0

  Copy full SHA for 1690ec0

• explicitly check if number of GPUs is not equal to 0.

  marenz2569

  committed
  dee9fc1

  Copy full SHA for dee9fc1

• update docstring in cuda and oneapi files

  marenz2569

  committed
  9c32916

  Copy full SHA for 9c32916

• add docstring for config

  marenz2569

  committed
  08a3772

  Copy full SHA for 08a3772

• fix offset in error detection algorithm. add docstrings

  marenz2569

  committed
  0de3fa6

  Copy full SHA for 0de3fa6

• docstring for DumpRegisterWorkerData

  marenz2569

  committed
  427675a

  Copy full SHA for 427675a

• add docstrings to Firestarter.hpp

  marenz2569

  committed
  e04716f

  Copy full SHA for e04716f

Commits on Nov 16, 2024

• fix bug saving json in history

  marenz2569

  committed
  32f1399

  Copy full SHA for 32f1399

• update comment in X86PlatformConfig.cpp

  marenz2569

  committed
  f045530

  Copy full SHA for f045530

Commits on Nov 19, 2024

• fix MiB print in cuda

  marenz2569

  committed
  b16aa6a

  Copy full SHA for b16aa6a

• unify firestarter includes for source files

  marenz2569

  committed
  0fce1bb

  Copy full SHA for 0fce1bb

Commits on Nov 20, 2024

• fix crash when optimization is stoped

  marenz2569

  committed
  9155ae2

  Copy full SHA for 9155ae2

Commits on Nov 21, 2024

• unify firestarter includes in header files

  marenz2569

  committed
  eb8eed7

  Copy full SHA for eb8eed7

• remove ifndefs

  marenz2569

  committed
  92897b2

  Copy full SHA for 92897b2

Commits on Nov 22, 2024

• silence modernice warning in c-style header

  marenz2569

  committed
  f53b736

  Copy full SHA for f53b736