Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add m2isar.backend.isa_manual #29

Open
wants to merge 3 commits into
base: coredsl2
Choose a base branch
from

Conversation

PhilippvK
Copy link
Member

update isa_manual backend (write behav)

add README for m2isar.backend.isa_manual

fix docstring
@PhilippvK PhilippvK requested a review from wysiwyng October 30, 2024 11:49
@PhilippvK PhilippvK self-assigned this Oct 30, 2024
# Chair of Electrical Design Automation
# Technical University of Munich

"""TODO"""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the todo


# pylint: disable=unused-argument

# import sys
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove commented lines

"""

MAKO_TEMPLATE_INSTR = """
==== ${name}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe move the mako templates to separate files, as with etiss_writer?

model_fname = abs_top_level
output_file = pathlib.Path(args.output)

if args.separate:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be implemented at some point?

@PhilippvK
Copy link
Member Author

@wysiwyng I have a more sophisticated coredsl2 writer backend coming up in a separate PR. Once this is ready, the isa_manual backend will just reuse that one for generating the behavior code. I can address the comments anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants