Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge hashtag dialogs into one #4861

Merged
merged 2 commits into from
Jan 14, 2025
Merged

merge hashtag dialogs into one #4861

merged 2 commits into from
Jan 14, 2025

Conversation

connyduck
Copy link
Collaborator

@connyduck connyduck commented Jan 10, 2025

A hashtag picker dialog was implemented twice, with slight differences.
Now there is only one

  • with hashtag validation - no more api errors when following an invalid one
  • The dialog can now be closed with the keyboard, for extra fast hashtag selection
  • with autocomplete

I also added a new snackbar when following a hashtag was succesfull.

Although I'm not sure about the auto complete, it can be very annoying as the drop down covers the buttons. I found no way to make it size to its content: https://chaos.social/@ConnyDuck/113803457147888844

Should we get rid of it?

@connyduck connyduck requested review from Tak, Lakoja and charlag January 10, 2025 10:04
@Lakoja
Copy link
Collaborator

Lakoja commented Jan 11, 2025

Are hashtags ascii-only?
The autocomplete and especially the final hashtag after the dialog will ignore/convert umlauts for example.

The autocomplete popup not being bounded by the keyboard probably is a problem (it extends below it). If you try to close the keyboard then first the popup is removed (and only on the second try the keyboard minimized).
Feature-wise however I would expect an autocomplete - as it is in the compose screen..

A bit odd that the text field border says "without #" but the autocomplete will show the proposals with #. It probably shouldn't.
(That would however collide with the behavior in compose screen.)
Maybe don't require and don't forbid it. Only if it is omitted in manual text input then add it later. That would most conform to the compose screen.

@connyduck
Copy link
Collaborator Author

Are hashtags ascii-only?
The autocomplete and especially the final hashtag after the dialog will ignore/convert umlauts for example.

Mastodon will convert them to ascii internally. So #häshtag and #hashtag may look differently, but are actually the same.
So I think its ok if we do that as well here.

I only meant getting rid of the autocomplete in this dialog, not everywhere.

@connyduck
Copy link
Collaborator Author

The thing with the dropdowns going under the keyboard affects other dialogs as well, I'm checking how it can be fixed everywhere

@connyduck connyduck merged commit 9735683 into develop Jan 14, 2025
1 check passed
@connyduck connyduck deleted the merge-hashtag-dialogs branch January 14, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants