Rolldown #8211
Open
Rolldown #8211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlag
force-pushed
the
rolldown
branch
6 times, most recently
from
acdb563 to
eb098bf
Compare
The issue was caused by the more button having a parent element with a `role="button"` resulting in the more button having a role of "presentation". To fix this, click handling was moved to a more button's sibling element (mail sender text). Close #8183
Co-authored-by: paw-hub <[email protected]>
The issue is being able to open labels dropdown even if there are no labels. Resolved by only showing dropdown if there are any labels found. close #8141
charlag
force-pushed
the
rolldown
branch
3 times, most recently
from
f4620bc to
d31b211
Compare
- switch desktop build to esm - convert mithril to esm - run worker as esm module - fix dependency from DesktopAlarmScheduler to calendar app - switch napi-rs cli to 3.0 - fix mimimi imports - remove hacky method on generated dispatcher - refactor native rollup plugins Co-authored-by: bir <[email protected]>
We need mimimi for type checking the project. It's not clear how it worked before.
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
worked around rolldown/rolldown#3287
worked around rolldown/rolldown#3292
and there's another crash related to import